This repository was archived by the owner on May 23, 2019. It is now read-only.
Make Browserify bundle work in ES3 environments#91
Merged
ericf merged 1 commit intoformatjs:masterfrom Jan 14, 2015
Merged
Conversation
|
CLA is valid! |
Collaborator
Author
There was a problem hiding this comment.
I could conditionally use O.dP here if we prefer the default prop to be non-enum, etc. in ES5+ environments.
Collaborator
There was a problem hiding this comment.
na, we should be ok with enum.
Collaborator
Author
There was a problem hiding this comment.
We can also revisit this after looking into and understanding how 6to5/esnext deals (or will deal with) inter-module-system deps.
Collaborator
|
LGTM |
ericf
added a commit
that referenced
this pull request
Jan 14, 2015
Make Browserify bundle work in ES3 environments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #90