Skip to content
This repository was archived by the owner on May 23, 2019. It is now read-only.

Make Browserify bundle work in ES3 environments #91

Merged
ericf merged 1 commit into from
Jan 14, 2015
Merged

Make Browserify bundle work in ES3 environments #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

'use strict';

var IntlMessageFormat = require('./lib/main').default;
var IntlMessageFormat = require('./lib/main')['default'];

// Add all locale data to `IntlMessageFormat`. This module will be ignored when
// bundling for the browser with Browserify/Webpack.
Expand All @@ -12,4 +12,4 @@ require('./lib/locales');
// locale data registered, and with English set as the default locale. Define
// the `default` prop for use with other compiled ES6 Modules.
exports = module.exports = IntlMessageFormat;
Object.defineProperty(exports, 'default', {value: exports});
exports['default'] = exports;
Copy link
Collaborator Author

@ericf ericf Jan 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could conditionally use O.dP here if we prefer the default prop to be non-enum, etc. in ES5+ environments.

Copy link
Collaborator

@caridy caridy Jan 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

na, we should be ok with enum.

Copy link
Collaborator Author

@ericf ericf Jan 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also revisit this after looking into and understanding how 6to5/esnext deals (or will deal with) inter-module-system deps.