Added reveal functionality for active tab in file explorer and enhanced studio shortcuts#491
Open
stijnpotters1 wants to merge 4 commits into
Open
Added reveal functionality for active tab in file explorer and enhanced studio shortcuts#491stijnpotters1 wants to merge 4 commits into
stijnpotters1 wants to merge 4 commits into
Conversation
philipsens
reviewed
May 20, 2026
Member
philipsens
left a comment
philipsens
left a comment
There was a problem hiding this comment.
Nice touch disabling the button when it's active.
Matthbo
reviewed
May 20, 2026
stijnpotters1
changed the title
|
Matthbo
reviewed
May 26, 2026
Comment on lines
+249
to
+269
| private ProjectDirectory resolveProjectDirectory(String projectName, String directoryPath) throws IOException { | ||
| try { | ||
| ConfigurationProject configurationProject = configurationProjectService.getProject(projectName); | ||
| Path projectPath = fileSystemStorage.toAbsolutePath(configurationProject.getRootPath()); | ||
| Path dirPath = fileSystemStorage.toAbsolutePath(directoryPath).normalize(); | ||
|
|
||
| if (!dirPath.startsWith(projectPath)) { | ||
| throw new SecurityException("Invalid path: outside project directory"); | ||
| } | ||
|
|
||
| if (!Files.exists(dirPath) || !Files.isDirectory(dirPath)) { | ||
| throw new IllegalArgumentException("Directory does not exist: " + dirPath); | ||
| } | ||
|
|
||
| boolean useRelativePaths = !fileSystemStorage.isLocalEnvironment(); | ||
| Path relativizeRoot = useRelativePaths ? fileSystemStorage.toAbsolutePath("") : projectPath; | ||
| return new ProjectDirectory(projectPath, dirPath, relativizeRoot, useRelativePaths); | ||
| } catch (ApiException _) { | ||
| throw new IllegalArgumentException("Project does not exist: " + projectName); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Git says this is new but doesnt this method exist already?
Contributor
Author
There was a problem hiding this comment.
Yes i delegated a big portion of the original getShallowDirectoryTree method into its own method so i could reuse it in the new getAncestorPath method
Contributor
Author
There was a problem hiding this comment.
Or do you mean something else?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Click on icon when tab is open and file tree closed
file tree opens to this opened tab
Also added shortcut actions to the studio file tree
