Rubbers meshGen fix and Gizmo positioning fix for rubbers and MWG#384
Merged
Conversation
selector old/new still inplace
Owner
|
Cool! Is this something that could go back to VPX? |
freezy
approved these changes
Mar 12, 2022
Owner
freezy
left a comment
freezy
left a comment
There was a problem hiding this comment.
Very cool! There is a warning about _middlePoint, says it's never assigned but used. Can it be removed?
Collaborator
Author
|
Have to look at it tomorrow. |
Cupiii
changed the title
Cupiii
changed the title
Cupiii
changed the title
Collaborator
Author
|
_middlepoint is set again for rubbers and MWG (where it was also not working). Changed PR Topic accordingly. Test run fine on my computer. |
Collaborator
Author
|
Oh, and yes, that may be backported to VP as well, but check for MWG branch, where I edited something in SplineVertex class. I think I only made the 2d spline non loopable, but i may have altered more without knowing. I should have used the 3dSpline Class which was used for Ramps... but did not... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue "Rubbers do not colllide sometimes #377".
Wrote Rubbers from scratch (copied some code from MWG).
Also fixed UV Mapping