Skip to content

Changes for not mounting entire NFS to each job#314

Merged
afgane merged 4 commits intomasterfrom
data_pvc
Apr 16, 2024
Merged

Changes for not mounting entire NFS to each job#314
afgane merged 4 commits intomasterfrom
data_pvc

Conversation

@almahmoud
Copy link
Member

@almahmoud almahmoud changed the title Changes for not mounting entire NFS to each job [WIP] Changes for not mounting entire NFS to each job Aug 13, 2021
@nuwang nuwang changed the title [WIP] Changes for not mounting entire NFS to each job Changes for not mounting entire NFS to each job Dec 20, 2021
Copy link
Member

@nuwang nuwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had made this review ages ago but forgotten to press the submit button!

{{- template "galaxy.pvcname" . -}}/config:{{ .Values.persistence.mountPath -}}/config,
{{- template "galaxy.pvcname" . -}}/deps:{{ .Values.persistence.mountPath -}}/deps,
{{- template "galaxy.pvcname" . -}}/object_store_cache:{{ .Values.persistence.mountPath -}}/object_store_cache,
{{- template "galaxy.pvcname" . -}}/tmp:{{ .Values.persistence.mountPath -}}/tmp,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Configure galaxy to use job working directory for tmp files?

{{- template "galaxy.pvcname" . -}}/object_store_cache:{{ .Values.persistence.mountPath -}}/object_store_cache,
{{- template "galaxy.pvcname" . -}}/tmp:{{ .Values.persistence.mountPath -}}/tmp,
{{- template "galaxy.pvcname" . -}}/tool-data:{{ .Values.persistence.mountPath -}}/tool-data,
{{- template "galaxy.pvcname" . -}}/tools:{{ .Values.persistence.mountPath -}}/tools,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mount as read-only?

{{ template "galaxy.pvcname" . -}}:{{ .Values.persistence.mountPath -}}
k8s_persistent_volume_claims: |-
{{ template "galaxy.pvcname" . -}}/cache:{{ .Values.persistence.mountPath -}}/cache,
{{- template "galaxy.pvcname" . -}}/config:{{ .Values.persistence.mountPath -}}/config,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove?

@afgane afgane merged commit 456fc6d into master Apr 16, 2024
@afgane afgane deleted the data_pvc branch April 16, 2024 20:55
ksuderman added a commit to ksuderman/galaxy-helm that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants