closing some issues towards v2.0 release#44
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #44 +/- ##
==========================================
- Coverage 97.50% 96.98% -0.52%
==========================================
Files 5 5
Lines 640 664 +24
==========================================
+ Hits 624 644 +20
- Misses 16 20 +4
🚀 New features to boost your workflow:
|
olexandr-konovalov
requested changes
May 14, 2026
Member
olexandr-konovalov
left a comment
olexandr-konovalov
left a comment
There was a problem hiding this comment.
I suggest the following changes, adding error messages
|
|
||
| h := DirectoriesPackageLibrary( "LocalNR", Concatenation( "Endom/", String( k ) ) ); | ||
| if IsEmpty( h ) then | ||
| return false; |
Member
There was a problem hiding this comment.
Instead of returning false, better to call an error:
Error("The library of local near rings of order ", k, " is not available");
| if IsEmpty( h ) then | ||
| return false; | ||
| else | ||
| w := Filename( h, Concatenation( "Endom", String( k ), "_", String( l ), "-", String( m ), "_", String( n ), ".txt" ) ); |
Member
There was a problem hiding this comment.
Should add a check if this part is not available
if w = fail then
Error("The library of local near rings with the additive group [", k ",", l, "] and multiplicative group [", m ",", n, "] is not available");
fi;
| #! $(r + a)s − rs\in I$ hold. | ||
| #! Main results accumulated for local nearrings | ||
| #! can be found in the surveys | ||
| #! <Cite Key="MR2799412"/> and <Cite Key="MR4943879"/>. |
Member
There was a problem hiding this comment.
@IrynaRaievska @raemarina please also add the bib file - the manual can not be built otherwise
olexandr-konovalov
requested changes
May 14, 2026
olexandr-konovalov
changed the title
olexandr-konovalov
changed the title
olexandr-konovalov
changed the title
olexandr-konovalov
force-pushed
the
assorted-changes
branch
from
d61bd88 to
47eca7a
Compare
This was referenced May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing #25, #28, #35, #40, #43, #45