Skip to content
This repository was archived by the owner on Jan 20, 2025. It is now read-only.

Tradução completa do arquivo using-fragments.md#136

Merged
jessescn merged 9 commits intogatsbyjs:masterfrom
fbandeirac:traducao-{using-fragments.md}
Jan 9, 2020
Merged

Tradução completa do arquivo using-fragments.md#136
jessescn merged 9 commits intogatsbyjs:masterfrom
fbandeirac:traducao-{using-fragments.md}

Conversation

@fbandeirac
Copy link
Contributor

@fbandeirac fbandeirac commented Dec 27, 2019

Qual o objetivo dessa pull request?

  • Adição de uma nova tradução
  • Correção em uma tradução existente

Qual arquivo foi traduzido/corrigido?

https://github.com/gatsbyjs/gatsby-pt-BR/blob/master/docs/docs/using-fragments.md

Algum comentário em relação a tradução?

Não traduzi a parte do código, pois achei que ficaria muito estranho.

@mauriciomutte mauriciomutte added the /docs File refering to /docs directory label Dec 27, 2019
iaurg
iaurg previously approved these changes Dec 27, 2019
View reviewed changes
Copy link
Contributor

@iaurg iaurg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muito boa a tradução, obrigado por contribuir 🎉

jessescn
jessescn suggested changes Dec 30, 2019
View reviewed changes
Copy link
Contributor

@jessescn jessescn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apenas algumas sugestões de correção

@jessescn jessescn mentioned this pull request Dec 30, 2019
Closed
@fbandeirac @jessescn
Update docs/docs/using-fragments.md
452a6eb 
Co-Authored-By: Jessé Souza <jesse.neto@ccc.ufcg.edu.br>
fbandeirac and others added 4 commits January 3, 2020 04:24
@fbandeirac @jessescn
Update docs/docs/using-fragments.md
a1d3756 
Co-Authored-By: Jessé Souza <jesse.neto@ccc.ufcg.edu.br>
@fbandeirac @jessescn
Update docs/docs/using-fragments.md
777647e 
Co-Authored-By: Jessé Souza <jesse.neto@ccc.ufcg.edu.br>
@fbandeirac @jessescn
Update docs/docs/using-fragments.md
653b655 
Co-Authored-By: Jessé Souza <jesse.neto@ccc.ufcg.edu.br>
@fbandeirac @jessescn
Update docs/docs/using-fragments.md
30a9315 
Co-Authored-By: Jessé Souza <jesse.neto@ccc.ufcg.edu.br>
@fbandeirac fbandeirac requested a review from jessescn January 3, 2020 07:26
@fbandeirac
Copy link
Contributor Author

fbandeirac commented Jan 3, 2020 •
edited
Loading

Apenas algumas sugestões de correção

Sugestões acatadas e anotadas! Obrigado!
É necessário fazer um re-pullrequest?

@rafaeelaudibert
Copy link
Contributor

rafaeelaudibert commented Jan 3, 2020

Não é necessário, elas aparecem aqui automaticamente!

rafaeelaudibert
rafaeelaudibert reviewed Jan 3, 2020
View reviewed changes
docs/docs/using-fragments.md
1. `FragmentName`: the name of the fragment that will be referenced later.
2. `TypeName`: the [GraphQL type](https://graphql.org/graphql-js/object-types/) of the object the fragment will be used on. This is important because you can only query for fields that actually exist on a given object.
3. The body of the query. You can define any fields with any level of nesting in here, the same that you would elsewhere in a GraphQL query
1. `FragmentName`: o nome do fragmento que será referenciado posteriormente.
Copy link
Contributor

@rafaeelaudibert rafaeelaudibert Jan 3, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O que você acha, será que não deveriamos traduzir FragmentName e TypeName?

Copy link
Contributor Author

@fbandeirac fbandeirac Jan 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meu pensamento inicial foi o seguinte: FragmentName é o nome dado pelo desenvolvedor para o Fragmento, não é um termo específico em inglês. Então achei que a compreensão do tipo de informação para quem está iniciando ou não sabe inglês seria mais fácil estando traduzido, evitando confusão com o resto do código. TypeName eu traduzi pq, apesar de tecnicamente fazer parte do código (pensando que será substituído por umTypeName em inglês), imaginei que, na parte do manual que abordar os TypeNames, o termo seria traduzido, já que é apenas referencia a termos.
Com a sugestão de manter o termo original, imaginei que se trata de algum padrão já adotado em outras partes da tradução, e aí já acatei.

rafaeelaudibert
rafaeelaudibert suggested changes Jan 3, 2020
View reviewed changes
Copy link
Contributor

@rafaeelaudibert rafaeelaudibert left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muito obrigado pelo PR @fbandeirac!

Fiz 2 3 pequenas sugestões, e um questionamento que talvez seria bacana decidirmos juntos.

fbandeirac and others added 3 commits January 3, 2020 21:15
@fbandeirac @rafaeelaudibert
Update docs/docs/using-fragments.md
019cccf 
Co-Authored-By: Rafael Baldasso Audibert <32079912+rafaeelaudibert@users.noreply.github.com>
@fbandeirac @rafaeelaudibert
Update docs/docs/using-fragments.md
35d0344 
Co-Authored-By: Rafael Baldasso Audibert <32079912+rafaeelaudibert@users.noreply.github.com>
@fbandeirac @rafaeelaudibert
Update docs/docs/using-fragments.md
1e0865d 
Co-Authored-By: Rafael Baldasso Audibert <32079912+rafaeelaudibert@users.noreply.github.com>
@iaurg iaurg requested a review from gabrielferreiraa January 7, 2020 12:38
rafaeelaudibert
rafaeelaudibert approved these changes Jan 8, 2020
View reviewed changes
Copy link
Contributor

@rafaeelaudibert rafaeelaudibert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ótimo! Muito obrigado pelas alterações! Apenas no agurado de mais 1 aprovação!

iaurg
iaurg approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@iaurg iaurg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muito boa a tradução, obrigado por contribuir 🤙

jessescn
jessescn approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@jessescn jessescn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Show de bola. Obrigado por contribuir com a comunidade Gatsby @fbandeirac! Fique livre para pedir outro arquivo para tradução, caso queira :)

@jessescn jessescn merged commit e727cdc into gatsbyjs:master Jan 9, 2020
@gatsbot
Copy link

gatsbot bot commented Jan 9, 2020

Holy buckets, @fbandeirac — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dennissiq dennissiq Awaiting requested review from dennissiq

@jay-jlm jay-jlm Awaiting requested review from jay-jlm

@gabrielferreiraa gabrielferreiraa Awaiting requested review from gabrielferreiraa

3 more reviewers

@iaurg iaurg iaurg approved these changes

@rafaeelaudibert rafaeelaudibert rafaeelaudibert approved these changes

@jessescn jessescn jessescn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

/docs File refering to /docs directory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fbandeirac @rafaeelaudibert @iaurg @jessescn @mauriciomutte