refactor(formatters): remove unused Granite32/33 processor classes#1337
Merged
planetf1 merged 4 commits intoJun 24, 2026
Conversation
…enerative-computing#1304) The Granite32InputProcessor, Granite32OutputProcessor, Granite32ChatCompletion, Granite33InputProcessor, Granite33OutputProcessor, and Granite33ChatCompletion classes were carried over from granite-common (generative-computing#571) but never wired into any backend or session routing. Mellea operates at the action/context level via intrinsic processors; the chat-message-level Granite3x pipeline was never used. Deletes the entire mellea/formatters/granite/granite3/ subtree (15 files), removes the six re-exported symbols from the top-level granite/__init__.py, and deletes the five test files that covered only this dead code. The nltk_check tests (base.optional) from the shared test file are rescued into test/formatters/granite/base/test_base_optional.py before deletion. Domain owner sign-off: frreiss confirmed removal in issue generative-computing#1304. Closes generative-computing#1304. Assisted-by: Claude Code Signed-off-by: Nigel Jones <jonesn@uk.ibm.com>
Removes the 15 mellea.formatters.granite.granite3* module entries that no longer exist after the previous commit deleted the granite3/ subtree. Updates total_symbols and coverage_percentage accordingly. Assisted-by: Claude Code Signed-off-by: Nigel Jones <jonesn@uk.ibm.com>
The previous commit pruned the granite3/* submodule keys but missed the parent mellea.formatters.granite block, which still listed all six removed symbols. This commit removes them and updates the symbol count (2035→2029) and coverage percentage (15.38→15.43%) accordingly. Assisted-by: Claude Code Signed-off-by: Nigel Jones <jonesn@uk.ibm.com>
…anite3 removal The only non-test consumers of find_substring_in_text lived in granite3/output.py, which was deleted in the previous commits. Remove the function and its dedicated test file; drop the now-unused re import from base/util.py. Assisted-by: Claude Code Signed-off-by: Nigel Jones <jonesn@uk.ibm.com>
planetf1
force-pushed
the
worktree-issue-1304
branch
from
June 24, 2026 14:23
6a0ac2f to
0130f3c
Compare
planetf1
marked this pull request as ready for review
June 24, 2026 14:28
planetf1
enabled auto-merge
June 24, 2026 14:34
jakelorocco
approved these changes
Jun 24, 2026
Merged
via the queue into
generative-computing:main
with commit Jun 24, 2026
cc62c8e
9 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mellea/formatters/granite/granite3/subtree (15 files) —Granite32InputProcessor,Granite32OutputProcessor,Granite32ChatCompletion,Granite33InputProcessor,Granite33OutputProcessor,Granite33ChatCompletion, and all their supporting classesmellea/formatters/granite/__init__.pyTestNltkCheck(coversbase.optional.nltk_check) into a newtest/formatters/granite/base/test_base_optional.pymellea.formatters.granite.granite3.*entries and the six Granite32/33 symbols from the parentmellea.formatters.graniteblock indocs/metrics/coverage-current.jsonThese classes were carried over from
granite-common(#571) but were never wired into any backend or session routing. Mellea operates at the action/context level via intrinsic processors; the chat-message-level Granite3x pipeline was never used.mellea-contribs: no references found.
Note:
test_granite33_output.pywas missing from the issue body but also existed and is removed here.Test plan
uv run pytest test/formatters/ -m "not qualitative"— 100 passed, 2 skippeduv run ruff check .anduv run ruff format --check .— cleanGranite3[23]orgranite3/submodules inmellea/,cli/, ortest/coverage-current.jsonhas zeroGranite32*/Granite33*entries undermellea.formatters.*pathsCloses #1304.