feat: Move functionality of granite-common to mellea by frreiss · Pull Request #571 · generative-computing/mellea

frreiss · 2026-03-04T01:21:19Z

Misc PR

Type of PR

Bug Fix
New Feature
Documentation
Other

Description

Link to Issue: feat: Move functionality of granite-common to Mellea #572

Move the functionality of https://github.com/ibm-granite/granite-common to Mellea. Place the new code under mellea.formatters. Update existing code in Mellea to use the imported code. Remove the dependency on the granite-common package.

Testing

Tests added to the respective file if code was changed
New code has 100% coverage if code as added
Ensure existing tests and github automation passes (a maintainer will kick off the github automation when the rest of the PR is populated)

Signed-off-by: Fred Reiss <frreiss@us.ibm.com>

chore: Merge changes from main

Signed-off-by: Fred Reiss <frreiss@us.ibm.com>

github-actions · 2026-03-04T01:21:29Z

The PR description has been updated. Please fill out the template for your PR to be reviewed.

mergify · 2026-03-04T01:21:52Z

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|release)(?:\(.+\))?:

jakelorocco

lgtm; tests pass and ran intrinsic tests locally too

- Fix incorrect **kwargs type annotation in elasticsearch.py (dict[str, int] -> Any) - Remove unnecessary type: ignore comments for imports now in pyproject.toml - Update CI pre-commit cache key to include uv.lock hash - Ensures MyPy re-checks files when dependencies change Fixes type errors introduced in generative-computing#571 that were masked by stale CI cache. Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com>

- Fix incorrect **kwargs type annotation in elasticsearch.py (dict[str, int] -> Any) - Remove unnecessary type: ignore comments for imports now in pyproject.toml - Update CI pre-commit cache key to include uv.lock hash - Ensures MyPy re-checks files when dependencies change Fixes type errors introduced in #571 that were masked by stale CI cache. Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com>

…uting#571) * Fix broken tests Signed-off-by: Fred Reiss <frreiss@us.ibm.com> * Update test outputs for upstream bug fix Signed-off-by: Fred Reiss <frreiss@us.ibm.com> * Import code from granite-common Signed-off-by: Fred Reiss <frreiss@us.ibm.com> --------- Signed-off-by: Fred Reiss <frreiss@us.ibm.com>

…rative-computing#579) - Fix incorrect **kwargs type annotation in elasticsearch.py (dict[str, int] -> Any) - Remove unnecessary type: ignore comments for imports now in pyproject.toml - Update CI pre-commit cache key to include uv.lock hash - Ensures MyPy re-checks files when dependencies change Fixes type errors introduced in generative-computing#571 that were masked by stale CI cache. Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com>

Upstream PR generative-computing#571 renamed GraniteCommonAdapter to IntrinsicAdapter. Update our _util.py to match before rebasing onto origin/main.

* Add uncertainty/certainty intrinsic support Wire up the uncertainty intrinsic from ibm-granite/granite-lib-core-r1.0 with a high-level check_certainty() API. The intrinsic evaluates model confidence in its response given a user question and assistant answer. - Add check_certainty(context, backend) in core.py - Extract shared call_intrinsic() helper into _util.py - Update catalog to point uncertainty at granite-lib-core-r1.0 - Add test, example, and README entry Co-Authored-By: ink-pad <inkit.padhi@gmail.com> * Fix uncertainty description in README Co-Authored-By: ink-pad <inkit.padhi@gmail.com> * Rename _call_intrinsic to call_intrinsic Drop the underscore prefix and alias — use call_intrinsic consistently across _util.py, rag.py, core.py, and test_rag.py. Co-Authored-By: ink-pad <inkit.padhi@gmail.com> * Rename GraniteCommonAdapter to IntrinsicAdapter in _util.py Upstream PR #571 renamed GraniteCommonAdapter to IntrinsicAdapter. Update our _util.py to match before rebasing onto origin/main. * Feat/requirement_check (#1) * Add uncertainty/certainty intrinsic support Wire up the uncertainty intrinsic from ibm-granite/granite-lib-core-r1.0 with a high-level check_certainty() API. The intrinsic evaluates model confidence in its response given a user question and assistant answer. - Add check_certainty(context, backend) in core.py - Extract shared call_intrinsic() helper into _util.py - Update catalog to point uncertainty at granite-lib-core-r1.0 - Add test, example, and README entry Co-Authored-By: ink-pad <inkit.padhi@gmail.com> * Fix uncertainty description in README Co-Authored-By: ink-pad <inkit.padhi@gmail.com> * Rename _call_intrinsic to call_intrinsic Drop the underscore prefix and alias — use call_intrinsic consistently across _util.py, rag.py, core.py, and test_rag.py. Co-Authored-By: ink-pad <inkit.padhi@gmail.com> * test * removed test file * added req check intrinsic * Update README.md * Update _util.py * updated files --------- Co-authored-by: ink-pad <inkit.padhi@gmail.com> Co-authored-by: manish-nagireddy <manish.nagireddy@ibm.com> * fix: add comment on repo structures * fix: linting * fix rc repo name * resolve rc references * fix: field ref in req check intrinsic --------- Co-authored-by: inkpad <inkit.padhi@ibm.com> Co-authored-by: Manish Nagireddy <65432909+mnagired@users.noreply.github.com> Co-authored-by: manish-nagireddy <manish.nagireddy@ibm.com> Co-authored-by: jakelorocco <59755218+jakelorocco@users.noreply.github.com>

…uting#571) * Fix broken tests Signed-off-by: Fred Reiss <frreiss@us.ibm.com> * Update test outputs for upstream bug fix Signed-off-by: Fred Reiss <frreiss@us.ibm.com> * Import code from granite-common Signed-off-by: Fred Reiss <frreiss@us.ibm.com> --------- Signed-off-by: Fred Reiss <frreiss@us.ibm.com>

…rative-computing#579) - Fix incorrect **kwargs type annotation in elasticsearch.py (dict[str, int] -> Any) - Remove unnecessary type: ignore comments for imports now in pyproject.toml - Update CI pre-commit cache key to include uv.lock hash - Ensures MyPy re-checks files when dependencies change Fixes type errors introduced in generative-computing#571 that were masked by stale CI cache. Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com>

…g#551) * Add uncertainty/certainty intrinsic support Wire up the uncertainty intrinsic from ibm-granite/granite-lib-core-r1.0 with a high-level check_certainty() API. The intrinsic evaluates model confidence in its response given a user question and assistant answer. - Add check_certainty(context, backend) in core.py - Extract shared call_intrinsic() helper into _util.py - Update catalog to point uncertainty at granite-lib-core-r1.0 - Add test, example, and README entry Co-Authored-By: ink-pad <inkit.padhi@gmail.com> * Fix uncertainty description in README Co-Authored-By: ink-pad <inkit.padhi@gmail.com> * Rename _call_intrinsic to call_intrinsic Drop the underscore prefix and alias — use call_intrinsic consistently across _util.py, rag.py, core.py, and test_rag.py. Co-Authored-By: ink-pad <inkit.padhi@gmail.com> * Rename GraniteCommonAdapter to IntrinsicAdapter in _util.py Upstream PR generative-computing#571 renamed GraniteCommonAdapter to IntrinsicAdapter. Update our _util.py to match before rebasing onto origin/main. * Feat/requirement_check (generative-computing#1) * Add uncertainty/certainty intrinsic support Wire up the uncertainty intrinsic from ibm-granite/granite-lib-core-r1.0 with a high-level check_certainty() API. The intrinsic evaluates model confidence in its response given a user question and assistant answer. - Add check_certainty(context, backend) in core.py - Extract shared call_intrinsic() helper into _util.py - Update catalog to point uncertainty at granite-lib-core-r1.0 - Add test, example, and README entry Co-Authored-By: ink-pad <inkit.padhi@gmail.com> * Fix uncertainty description in README Co-Authored-By: ink-pad <inkit.padhi@gmail.com> * Rename _call_intrinsic to call_intrinsic Drop the underscore prefix and alias — use call_intrinsic consistently across _util.py, rag.py, core.py, and test_rag.py. Co-Authored-By: ink-pad <inkit.padhi@gmail.com> * test * removed test file * added req check intrinsic * Update README.md * Update _util.py * updated files --------- Co-authored-by: ink-pad <inkit.padhi@gmail.com> Co-authored-by: manish-nagireddy <manish.nagireddy@ibm.com> * fix: add comment on repo structures * fix: linting * fix rc repo name * resolve rc references * fix: field ref in req check intrinsic --------- Co-authored-by: inkpad <inkit.padhi@ibm.com> Co-authored-by: Manish Nagireddy <65432909+mnagired@users.noreply.github.com> Co-authored-by: manish-nagireddy <manish.nagireddy@ibm.com> Co-authored-by: jakelorocco <59755218+jakelorocco@users.noreply.github.com>

…enerative-computing#1304) The Granite32InputProcessor, Granite32OutputProcessor, Granite32ChatCompletion, Granite33InputProcessor, Granite33OutputProcessor, and Granite33ChatCompletion classes were carried over from granite-common (generative-computing#571) but never wired into any backend or session routing. Mellea operates at the action/context level via intrinsic processors; the chat-message-level Granite3x pipeline was never used. Deletes the entire mellea/formatters/granite/granite3/ subtree (15 files), removes the six re-exported symbols from the top-level granite/__init__.py, and deletes the five test files that covered only this dead code. The nltk_check tests (base.optional) from the shared test file are rescued into test/formatters/granite/base/test_base_optional.py before deletion. Domain owner sign-off: frreiss confirmed removal in issue generative-computing#1304. Closes generative-computing#1304. Assisted-by: Claude Code Signed-off-by: Nigel Jones <jonesn@uk.ibm.com>

…enerative-computing#1337) * refactor(formatters): remove unused Granite32/33 processor classes (generative-computing#1304) The Granite32InputProcessor, Granite32OutputProcessor, Granite32ChatCompletion, Granite33InputProcessor, Granite33OutputProcessor, and Granite33ChatCompletion classes were carried over from granite-common (generative-computing#571) but never wired into any backend or session routing. Mellea operates at the action/context level via intrinsic processors; the chat-message-level Granite3x pipeline was never used. Deletes the entire mellea/formatters/granite/granite3/ subtree (15 files), removes the six re-exported symbols from the top-level granite/__init__.py, and deletes the five test files that covered only this dead code. The nltk_check tests (base.optional) from the shared test file are rescued into test/formatters/granite/base/test_base_optional.py before deletion. Domain owner sign-off: frreiss confirmed removal in issue generative-computing#1304. Closes generative-computing#1304. Assisted-by: Claude Code Signed-off-by: Nigel Jones <jonesn@uk.ibm.com> * docs(metrics): remove stale Granite3x entries from coverage snapshot Removes the 15 mellea.formatters.granite.granite3* module entries that no longer exist after the previous commit deleted the granite3/ subtree. Updates total_symbols and coverage_percentage accordingly. Assisted-by: Claude Code Signed-off-by: Nigel Jones <jonesn@uk.ibm.com> * docs(metrics): remove Granite32/33 from parent granite formatter entry The previous commit pruned the granite3/* submodule keys but missed the parent mellea.formatters.granite block, which still listed all six removed symbols. This commit removes them and updates the symbol count (2035→2029) and coverage percentage (15.38→15.43%) accordingly. Assisted-by: Claude Code Signed-off-by: Nigel Jones <jonesn@uk.ibm.com> * refactor(formatters): remove find_substring_in_text now dead after granite3 removal The only non-test consumers of find_substring_in_text lived in granite3/output.py, which was deleted in the previous commits. Remove the function and its dedicated test file; drop the now-unused re import from base/util.py. Assisted-by: Claude Code Signed-off-by: Nigel Jones <jonesn@uk.ibm.com> --------- Signed-off-by: Nigel Jones <jonesn@uk.ibm.com>

frreiss added 5 commits February 26, 2026 16:31

Fix broken tests

af28e0b

Signed-off-by: Fred Reiss <frreiss@us.ibm.com>

Merge branch 'granite_common' into tmp_merge

8435d5c

Merge pull request #4 from frreiss/tmp_merge

6214860

chore: Merge changes from main

Update test outputs for upstream bug fix

c62336d

Signed-off-by: Fred Reiss <frreiss@us.ibm.com>

Import code from granite-common

39269f8

Signed-off-by: Fred Reiss <frreiss@us.ibm.com>

frreiss requested a review from jakelorocco March 4, 2026 01:21

frreiss requested a review from a team as a code owner March 4, 2026 01:21

jakelorocco approved these changes Mar 4, 2026

View reviewed changes

jakelorocco added this pull request to the merge queue Mar 4, 2026

Merged via the queue into generative-computing:main with commit 6901c93 Mar 4, 2026
9 checks passed

ajbozarth mentioned this pull request Mar 5, 2026

fix: correct type annotations and improve CI cache invalidation #579

Merged

8 tasks

frreiss mentioned this pull request Mar 9, 2026

test: Add tests for intrinsics-related formatters #609

Merged

4 tasks

This was referenced Mar 16, 2026

feat: port context-attribution intrinsic from granite-common #660

Closed

feat: port context-attribution intrinsic from granite-common #661

Closed

psschwei mentioned this pull request Mar 20, 2026

chore: use github tooling to build release notes #710

Merged

8 tasks

planetf1 mentioned this pull request Jun 19, 2026

Remove unused Granite32/33 formatter processors from public API #1304

Closed

planetf1 mentioned this pull request Jun 24, 2026

refactor(formatters): remove unused Granite32/33 processor classes #1337

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Move functionality of granite-common to mellea#571

feat: Move functionality of granite-common to mellea#571
jakelorocco merged 5 commits into
generative-computing:mainfrom
frreiss:granite_common

frreiss commented Mar 4, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Mar 4, 2026

Uh oh!

mergify Bot commented Mar 4, 2026

Uh oh!

jakelorocco left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

frreiss commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Misc PR

Type of PR

Description

Testing

Uh oh!

github-actions Bot commented Mar 4, 2026

Uh oh!

mergify Bot commented Mar 4, 2026

Merge Protections

🟢 Enforce conventional commit

Uh oh!

jakelorocco left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

frreiss commented Mar 4, 2026 •

edited

Loading