Skip to content

docs: removed outdated tutorial.md#555

Merged
psschwei merged 2 commits into
generative-computing:mainfrom
psschwei:drop-tutorial
Mar 17, 2026
Merged

docs: removed outdated tutorial.md#555
psschwei merged 2 commits into
generative-computing:mainfrom
psschwei:drop-tutorial

Conversation

@psschwei

@psschwei psschwei commented Feb 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Misc PR

Type of PR

  • Bug Fix
  • New Feature
  • Documentation
  • Other

Description

Testing

  • Tests added to the respective file if code was changed
  • New code has 100% coverage if code as added
  • Ensure existing tests and github automation passes (a maintainer will kick off the github automation when the rest of the PR is populated)

@psschwei
psschwei requested a review from a team as a code owner February 24, 2026 18:16
@github-actions

github-actions Bot commented Feb 24, 2026

Copy link
Copy Markdown
Contributor

The PR description has been updated. Please fill out the template for your PR to be reviewed.

@mergify

mergify Bot commented Feb 24, 2026

Copy link
Copy Markdown

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|release)(?:\(.+\))?:

@ajbozarth

ajbozarth commented Feb 24, 2026

Copy link
Copy Markdown
Contributor

Given this wholesale removes the current tutorial I assume its content is duplicated/up to date elsewhere. If so we should probably link that here and in the issue for reference and review

@psschwei

psschwei commented Feb 24, 2026

Copy link
Copy Markdown
Member Author

#361 decomposes the tutorial, though updates since that PR was opened would still need to be added.

@planetf1

planetf1 commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

There are some lingering links

README.md

232: See the tutorial
236: Please refer to the Contributor Guide for detailed instructions on how to contribute.

mellea/stdlib/functional.py

Line 484 contains an error message with a hardcoded GitHub link: See the async section of the tutorial: https://github.com/generative-computing/mellea/blob/main/docs/tutorial.md#chapter-12-asynchronicity

@psschwei

psschwei commented Feb 26, 2026

Copy link
Copy Markdown
Member Author

content being rewritten, and that will also tackle removing old tutorial

@psschwei psschwei closed this Feb 26, 2026
@psschwei

psschwei commented Mar 13, 2026

Copy link
Copy Markdown
Member Author

reopening

@psschwei psschwei reopened this Mar 13, 2026
@psschwei
docs: removed outdated tutorial.md
3219a87 
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
@psschwei
psschwei enabled auto-merge March 13, 2026 16:13
@planetf1

planetf1 commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

Still lingering links (from upstream/main as of now) which need resolution

README.md:188 — See the tutorial
CONTRIBUTING.md:427 — Tutorial
mellea/stdlib/functional.py:528 — hardcoded GitHub URL in an error message pointing to tutorial.md#chapter-12-asynchronicity

planetf1
planetf1 requested changes Mar 17, 2026
View reviewed changes

@planetf1 planetf1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

links need fixing

@psschwei
dropping additional references to tutorial.md
de1c933 
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
@psschwei

psschwei commented Mar 17, 2026

Copy link
Copy Markdown
Member Author

links need fixing

done

@planetf1 planetf1 mentioned this pull request Mar 17, 2026
Merged
9 tasks
planetf1
planetf1 approved these changes Mar 17, 2026
View reviewed changes

@planetf1 planetf1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - links are fixed

@psschwei
psschwei added this pull request to the merge queue Mar 17, 2026
Merged via the queue into generative-computing:main with commit a0e2a46 Mar 17, 2026
6 checks passed
@psschwei psschwei mentioned this pull request Mar 20, 2026
Merged
8 tasks
@psschwei
psschwei deleted the drop-tutorial branch May 5, 2026 12:44
akihikokuroda pushed a commit to akihikokuroda/mellea that referenced this pull request May 27, 2026
@psschwei @akihikokuroda
docs: removed outdated tutorial.md (generative-computing#555)
9f309c9 
* docs: removed outdated tutorial.md

Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>

* dropping additional references to tutorial.md

Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>

---------

Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@planetf1 planetf1 planetf1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@psschwei @ajbozarth @planetf1