Skip to content

Update to new version of OWSlib - #312

Closed
borrob wants to merge 2 commits into
geopython:masterfrom
borrob:update_owslib
Closed

Update to new version of OWSlib#312
borrob wants to merge 2 commits into
geopython:masterfrom
borrob:update_owslib

Conversation

@borrob

@borrob borrob commented Jan 17, 2020

Copy link
Copy Markdown
Collaborator

With the update to py3 (PR #280) we had to postpone the upgrade to OWSLib because of issue geopython/OWSLib#614. This was discussed under "number 3" of the PR review.

In the mean time the issue with OWSLib is solved, so it is save to upgrade.

@borrob borrob added the dependencies Pull requests that update a dependency file label Jan 17, 2020
@borrob borrob self-assigned this Jan 17, 2020
@justb4

justb4 commented May 31, 2020

Copy link
Copy Markdown
Member

This PR is needed more than ever, see recent Gitter chat on WFS auth. By this time there is OWSLib 0.19.2. Most of the work is in regression testing as OWSLib is used in many Probes in many scenario's (e.g. with auth headers) and some workarounds e.g. for WFS3 were made.

@justb4
justb4 self-requested a review October 26, 2020 09:57
@justb4 justb4 added this to the Version 0.8.1 milestone Oct 26, 2020
@justb4

justb4 commented Oct 26, 2020

Copy link
Copy Markdown
Member

@borrob I will work from a new branch: https://github.com/geopython/GeoHealthCheck/tree/owslib-upgrade , sorry, sometimes my git-knowledge is not sufficient..

@justb4 justb4 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, sorry @borrob . This PR is superseded by PR #333 that just went in. It involved quite some intricate changes as well (and solved several outstanding issues). So closing this PR.

@justb4

justb4 commented Oct 27, 2020

Copy link
Copy Markdown
Member

Closing as solved/superseded by #333.

@justb4 justb4 closed this Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants