upgrade OWSLib to 0.20.0 and fix WFS3 (OAPIF) Probes - #333
Conversation
tomkralidis
left a comment
tomkralidis
left a comment
There was a problem hiding this comment.
Looks good. Only comments are to consider harmonizing based on the following long and short names (in the name of more OGC API support in GHC in the future):
OGC API - Features- OAFeat
| @@ -1,25 +1,64 @@ | |||
| import requests | |||
There was a problem hiding this comment.
Should we rename this file to GeoHealthCheck/plugins/probe/oafeat.py?
There was a problem hiding this comment.
Normally would agree. Only this is not a simple name change: like resource_type OGC:WFS3, the Probe class package string is stored in the DB (probe_vars table, column probe_class) like GeoHealthCheck.plugins.probe.wfs3.WFS3Caps. So this would require an Alembic DB upgrade as well. I propose to do this in separate issue/PR.
There was a problem hiding this comment.
OK. +1 to cover in another issue/PR.
There was a problem hiding this comment.
See my comment above. I agree that we should align naming for OAFeat. (Was not even aware of the most recent naming.) But this PR is mainly the OWSLib upgrade, causing bugs fixed for OWS Authentication (headers param WFS and TMS) and a need to rewrite WFS3/OAFeat Probe code. Was more involved than planned. That next PR would then be for #313.
There was a problem hiding this comment.
Though renaming OAPIF to OAFeat (is that the new name?) in the comments and some code is ok. Only the Probe class names GeoHealthCheck.plugins.probe.wfs3.* and Resource Type OGC:WFS3 have DB-impact.
2 participants
This PR supersedes PR #312
ogcapiclient classesNB renaming all in GHC from WFS3 to OAPIF is too involved now, as this would require DB updates in existing installations...