WFS 2.0 URL building#612
Merged
Merged
Conversation
Member
|
This Pull Request has been inactive for 90 days. In order to manage maintenance burden, it will be automatically closed in 7 days. |
Contributor
Author
|
Pull request rebased onto latest master branch and all tests passing. The coveralls check is failing - it reports -0.006% coverage change, but I don't think this is correct - the changes in this pull requests are tested as previously. It also reported -0.2% on another run with the same code. I ran into a similar issue on MapServer with small changes between runs. We increased the threshold to 1% to avoid this (see MapServer/MapServer#6223). Maybe OWSLib is also required to have 60% coverage? |
This was referenced Oct 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In WFS 2.0 GetFeature requests currently fail for MapServer URLs containing
?map=path/my.map&This is the same issue as #533 - and unfortunately I missed that there was also an open pull request at #534 from @samtux
The approach in this pull request is slightly different - it reuses the
build_get_urlfunction from utils.A few other notes:
owslib\util.py:561: DeprecationWarning: cgi.parse_qsl is deprecated, use urllib.parse.parse_qsl insteadso this has been updateddoseqand URLs with ampersands