Fix Avalon-Nuke implementation#471
Merged
Merged
Conversation
The function `ls_img_sequence` has been removed in commit 74c969d
Instead of hard-coded to use pyblish-lite, use pyblish.register_gui.
Collaborator
Author
|
Before I actually step into #438, I need this PR to be merged. |
tokejepsen
approved these changes
Nov 5, 2019
Collaborator
tokejepsen
left a comment
There was a problem hiding this comment.
Cant test, but the code good.
Collaborator
Author
|
For completeness, here's the error message I got while launching before this PR. And Nuke went down. |
BigRoy
approved these changes
Nov 5, 2019
Collaborator
BigRoy
left a comment
There was a problem hiding this comment.
Can't test on my end but the code changes look good to me.
Collaborator
Author
|
Merging this ! 🚀 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Nuke launched from Avalon will instantly crashed due to some missing function and module-not-found error.
What's changed
tomlfromavalon.vendor(c78255b)ls_img_sequence(fb4cde5)pyblish-lite, revert back to useavalon.tools.publishso one can register any pyblish GUI on demand via usingpyblish.register_guiin config module. (Also, did not encounter Doesn't work with Nuke pyblish/pyblish-qml#301, even so, no reason to hard code for fix 😌 ) (b668318)