Porting#438#484
Merged
Merged
Conversation
tokejepsen
reviewed
Dec 13, 2019
| [n['selected'].setValue(True) for n in previous_selection] | ||
|
|
||
|
|
||
| def reset_selection(): |
Collaborator
There was a problem hiding this comment.
Maybe deselect_all is a better name?
Collaborator
Author
There was a problem hiding this comment.
Yeah, @jezscha what do you think ?
Collaborator
Author
There was a problem hiding this comment.
Hmm, no wait. Since this isn't a new function that introduced here and already been used, so we better not to change the name. 🤔
Contributor
There was a problem hiding this comment.
Hi @davidlatwe sorry for the slow response.. Yes please this is used many times.. anyway you could rename it but link this for backward compatibility
Collaborator
Author
There was a problem hiding this comment.
I can live with current name :)
Collaborator
Author
|
Merging this :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is aim to resolve #438.
PR #438 was huge, and a few parts of it was build on top of old tech-debt. But after PR #471, #473, #476, I think this is the final piece to finish up the rest.
What's changed
nuke.lsnow listing containers from all types of nodes, not justReadtype node.nuke.Creatorto allow instance to have multiple nodes with backdrop.nuke.commandand move util functions fromnuke.pipelineto there. (Backwards compatible)nuke.libPlease let me know if there's anything missing or broken. @jezscha