perf(android): [SDK Overhead Reduction 3] Reuse SentryExecutorService for DeviceInfoUtil pre-caching#5502
Draft
adinauer wants to merge 1 commit into
Conversation
…hing Replace Executors.newSingleThreadExecutor() with options.getExecutorService() in DefaultAndroidEventProcessor to avoid creating a dedicated thread during init. The SDK already has an executor service available.
📲 Install BuildsAndroid
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (SDK Overhead Reduction)
📜 Description
Replace
Executors.newSingleThreadExecutor()withoptions.getExecutorService()inDefaultAndroidEventProcessorfor theDeviceInfoUtilpre-caching task. This avoids creating a dedicated thread + executor during SDK init when the SDK already has an executor service available. Also removes theexecutorService.shutdown()call since we don't own the shared executor.💡 Motivation and Context
Part of the SDK Overhead Reduction stack. During Android SDK init,
DefaultAndroidEventProcessorwas creating its ownSingleThreadExecutorjust to submit one task for pre-caching device info. The SDK's executor service (SentryExecutorService) is already available at this point and can handle this work without the overhead of spinning up an additional thread pool.💚 How did you test it?
./gradlew :sentry-android-core:compileDebugUnitTestJavaWithJavac— compiles successfully./gradlew spotlessApply apiDump— no API surface changes📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
More SDK overhead reduction PRs in this stack.
#skip-changelog