perf: Drop pending timer tasks on shutdown to unblock close (JAVA-653) - #5851
Open
runningcode wants to merge 2 commits into
Open
perf: Drop pending timer tasks on shutdown to unblock close (JAVA-653)#5851runningcode wants to merge 2 commits into
runningcode wants to merge 2 commits into
Conversation
runningcode
requested review from
0xadam-brown,
adinauer,
markushi and
romtsn
as code owners
July 29, 2026 09:35
📲 Install BuildsAndroid
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d15471f | 369.38 ms | 459.08 ms | 89.70 ms |
| bbc35bb | 324.88 ms | 425.73 ms | 100.85 ms |
| b193867 | 319.59 ms | 403.09 ms | 83.50 ms |
| 62b579c | 299.75 ms | 364.84 ms | 65.09 ms |
| 382d6c1 | 306.85 ms | 368.70 ms | 61.85 ms |
| 48277cd | 320.38 ms | 379.90 ms | 59.52 ms |
| 5b1a06b | 315.40 ms | 353.33 ms | 37.94 ms |
| ee747ae | 415.92 ms | 470.15 ms | 54.23 ms |
| 37ec571 | 366.04 ms | 424.28 ms | 58.23 ms |
| 462dea2 | 277.68 ms | 359.83 ms | 82.15 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d15471f | 1.58 MiB | 2.13 MiB | 559.54 KiB |
| bbc35bb | 1.58 MiB | 2.12 MiB | 553.01 KiB |
| b193867 | 1.58 MiB | 2.19 MiB | 620.00 KiB |
| 62b579c | 0 B | 0 B | 0 B |
| 382d6c1 | 1.58 MiB | 2.29 MiB | 719.85 KiB |
| 48277cd | 0 B | 0 B | 0 B |
| 5b1a06b | 0 B | 0 B | 0 B |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| 37ec571 | 0 B | 0 B | 0 B |
| 462dea2 | 0 B | 0 B | 0 B |
runningcode
commented
Jul 29, 2026
| } | ||
|
|
||
| @Test | ||
| fun `SentryExecutorService discards pending delayed tasks on shutdown when requested`() { |
Contributor
Author
There was a problem hiding this comment.
Not sure we really need these tests.
Member
There was a problem hiding this comment.
I think the inline comment is enough to prevent regressions, so my vote would be to remove...
8 tasks
runningcode
added
the
sanity-check
0xadam-brown
approved these changes
Jul 29, 2026
0xadam-brown
left a comment
0xadam-brown
left a comment
Member
There was a problem hiding this comment.
Nice!
Does it make sense to apply the same policy to other / all of our Sentry executor services? (Doesn't have to stop us from merging this PR)
| } | ||
|
|
||
| @Test | ||
| fun `SentryExecutorService discards pending delayed tasks on shutdown when requested`() { |
Member
There was a problem hiding this comment.
I think the inline comment is enough to prevent regressions, so my vote would be to remove...
romtsn
approved these changes
Jul 30, 2026
The timer executor is shut down by Scopes.close() via shutdown() followed by awaitTermination(). ScheduledThreadPoolExecutor keeps queued delayed tasks across shutdown() by default, so awaitTermination() blocks for the full shutdown timeout (2s by default) whenever a long timeout is still pending: an unfinished transaction's idle/deadline timer, the 30s LifecycleWatcher end-session task, or a rate limit lifted notification. Those tasks are discarded by the subsequent shutdownNow() anyway, so dropping them upfront is behaviour preserving and only saves the wait. This only affects shutdown(), so the SDK restart path that intentionally leaves the timer executor running is unaffected. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
runningcode
force-pushed
the
no/perf/timer-executor-shutdown-policy
branch
from
August 4, 2026 14:43
c9c256e to
08e41f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up on this comment: https://github.com/getsentry/sentry-java/pull/5814/changes#r3667006204
The timer executor is shut down in
Scopes.close()viashutdown()followed byawaitTermination(shutdownTimeoutMillis).ScheduledThreadPoolExecutorkeeps queued delayed tasks acrossshutdown()by default, soawaitTerminationblocks for the full shutdown timeout (2s by default) whenever a long timeout is still pending at close time:SentryTracer)LifecycleWatcherend-session task, only cancelled on foregroundingRateLimiter, up toretry_after)Setting
executeExistingDelayedTasksAfterShutdownPolicy(false)drops those tasks atshutdown()instead. This is behaviour preserving: today they are discarded by the subsequentshutdownNow()once the timeout expires anyway, so the only thing lost is the wait.The policy only affects
shutdown(), so the SDK restart path that intentionally leaves the timer executor running (Scopes.close(isRestarting = true)) is unaffected. Scoped to the timer executor's constructor — the general-purpose executor keeps the default.Measured with a standalone repro using the same executor configuration, one pending 60s task and a 2s timeout:
terminatedfalsetrue🤖 Generated with Claude Code