Skip to content

perf: Drop pending timer tasks on shutdown to unblock close (JAVA-653) #5851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
runningcode wants to merge 3 commits into
base: main
Choose a base branch
from
+5 −0
Open

perf: Drop pending timer tasks on shutdown to unblock close (JAVA-653) #5851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e86602b
perf: Drop pending timer tasks on shutdown to unblock close (JAVA-653)
runningcode Jul 29, 2026
08e41f2
changelog
runningcode Jul 29, 2026
b5d9bea
test: Drop SentryExecutorService shutdown policy tests (JAVA-653)
runningcode Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

### Performance

- Avoid waiting up to `shutdownTimeoutMillis` when closing the SDK with a pending transaction timeout or session-end task ([#5851](https://github.com/getsentry/sentry-java/pull/5851))
- Use `RGB_565` instead of `ARGB_8888` for screenshot and replay capture bitmaps, halving per-frame memory usage ([#5821](https://github.com/getsentry/sentry-java/pull/5821))
- Remove an unused lock from `SentryPerformanceProvider`, which was allocated on every cold start in `ContentProvider.onCreate` without ever being acquired ([#5871](https://github.com/getsentry/sentry-java/pull/5871))
- Parse the app start profiling config with only the deserializer it needs instead of building a full `JsonSerializer` and `SentryOptions`, cutting 188 of 221 allocations on the main thread before `Application.onCreate` ([#5867](https://github.com/getsentry/sentry-java/pull/5867))
Expand Down
4 changes: 4 additions & 0 deletions sentry/src/main/java/io/sentry/SentryExecutorService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,10 @@ public SentryExecutorService(final @Nullable SentryOptions options) {
executorService.setRemoveOnCancelPolicy(removeOnCancelPolicy);
executorService.setKeepAliveTime(keepAliveTime, keepAliveTimeUnit);
executorService.allowCoreThreadTimeOut(true);
// by default shutdown() keeps queued delayed tasks, so awaitTermination blocks for the full
// shutdown timeout whenever a long timeout is still pending. Those tasks are discarded by the
// subsequent shutdownNow() anyway, so dropping them upfront only saves the wait.
Comment thread
runningcode marked this conversation as resolved.
executorService.setExecuteExistingDelayedTasksAfterShutdownPolicy(false);
}

public SentryExecutorService() {
Expand Down
Loading