feat(billing): add tax_pending to RolloverContractRequest#287
Draft
dashed wants to merge 1 commit into
Draft
Conversation
|
The latest Buf updates on your PR. Results from workflow ci / buf-checks (pull_request).
|
dashed
force-pushed
the
aleal/feat/contract-sales-tax
branch
from
c040360 to
d4052c4
Compare
dashed
force-pushed
the
aleal/feat/contract-tax-pending
branch
from
34e7c23 to
7cf0f60
Compare
dashed
force-pushed
the
aleal/feat/contract-sales-tax
branch
from
729d1fc to
42df697
Compare
dashed
force-pushed
the
aleal/feat/contract-tax-pending
branch
from
7cf0f60 to
1434c6e
Compare
dashed
force-pushed
the
aleal/feat/contract-sales-tax
branch
from
c407799 to
7ae8585
Compare
dashed
force-pushed
the
aleal/feat/contract-tax-pending
branch
from
d7bf1a0 to
6cd2d23
Compare
When tax cannot be computed at contract rollover (the tax provider is unavailable), tax_pending marks the invoice so it is created without a tax line item and held back from charging until a later sweep backfills the tax. Regenerates the Rust bindings.
dashed
force-pushed
the
aleal/feat/contract-tax-pending
branch
from
127467d to
6cbe87b
Compare
This was referenced Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
bool tax_pending = 7toRolloverContractRequest.When the tax provider is unavailable at rollover time, the tax cannot be computed.
tax_pendingmarks such an invoice so it is created without a tax line item and held back from charging until a later sweep recomputes and backfills the tax.Field layout (RolloverContractRequest)
pending_changereserved(former sales_tax slot, removed in #286)tax_pendingRust bindings regenerated via
make build-rust; Python bindings viamake build-py(py/is gitignored).Stacking
main→ #293 (InvoiceLineItem.type) → #286 (tax_number) → this PR. Review/merge in order.Test plan
make build-py+make build-rustsucceedbuf lint/buf formatpass