feat(billing): add optional type to InvoiceLineItem#293
Merged
Conversation
Line items can now carry an optional type classifier (e.g. "tax") so consumers can treat a line item specially without parsing its description. Regenerates the Rust bindings.
|
The latest Buf updates on your PR. Results from workflow ci / buf-checks (pull_request).
|
This was referenced Jun 5, 2026
brendanhsentry
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an
optional string type = 3field toInvoiceLineItem(proto/sentry_protos/billing/v1/services/contract/v1/invoice.proto).This lets a line item carry a classifier (e.g.
"tax") so consumers can treat it specially without parsing the human-readabledescription. It is the foundation for representing sales tax as an ordinary, typed entry inline_itemsrather than a dedicated request field.Field layout (InvoiceLineItem)
amount_centsdescriptiontypeRust bindings regenerated via
make build-rust; Python bindings viamake build-py(py/is gitignored).Test plan
make build-py+make build-rustsucceedbuf lint/buf formatpass