feat(difs): Exclusive Objectstore write for legacy DIF uploads - #120876
Closed
lcian wants to merge 4 commits into
Closed
feat(difs): Exclusive Objectstore write for legacy DIF uploads#120876lcian wants to merge 4 commits into
lcian wants to merge 4 commits into
Conversation
Under organizations:objectstore-debugfiles-exclusive-write, route zip/dSYM uploads and ProGuard clone reuploads through create_objectstore_dif_from_id so no File row is created.
lcian
marked this pull request as draft
July 30, 2026 10:28
…tore-debugfiles-legacy-uploads
…tore-debugfiles-legacy-uploads
Member
Author
|
Superseded by #120184, which now uses the unified |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends
organizations:objectstore-debugfiles-exclusive-writebeyond chunk-upload + assemble so remaining legacy DIF upload paths also write exclusively to Objectstore (noFilerow):DebugFilesEndpoint→create_files_from_dif_zip→create_debug_file_from_dif) routes throughcreate_objectstore_dif_from_idwhen the flag is on._clone_proguard_debug_file_for_reupload) always produces an Objectstore-only clone under the flag, regardless of whether the source is File-backed, dual-written, or already Objectstore-only.Also extracts
_checksum_and_sizefor shared hashing used by zip exclusive-write andcreate_dif_from_id.Closes FS-365