Skip to content

feat(difs): Exclusive Objectstore write for legacy DIF uploads - #120876

Closed
lcian wants to merge 4 commits into
feat/objectstore-debugfiles-assemblefrom
feat/objectstore-debugfiles-legacy-uploads
Closed

feat(difs): Exclusive Objectstore write for legacy DIF uploads#120876
lcian wants to merge 4 commits into
feat/objectstore-debugfiles-assemblefrom
feat/objectstore-debugfiles-legacy-uploads

Conversation

@lcian

@lcian lcian commented Jul 30, 2026

Copy link
Copy Markdown
Member

⚠️ Stacked on #120184

Extends organizations:objectstore-debugfiles-exclusive-write beyond chunk-upload + assemble so remaining legacy DIF upload paths also write exclusively to Objectstore (no File row):

  • Zip / dSYM upload (DebugFilesEndpointcreate_files_from_dif_zipcreate_debug_file_from_dif) routes through create_objectstore_dif_from_id when the flag is on.
  • ProGuard clone / reupload (_clone_proguard_debug_file_for_reupload) always produces an Objectstore-only clone under the flag, regardless of whether the source is File-backed, dual-written, or already Objectstore-only.

Also extracts _checksum_and_size for shared hashing used by zip exclusive-write and create_dif_from_id.

Closes FS-365

Under organizations:objectstore-debugfiles-exclusive-write, route zip/dSYM
uploads and ProGuard clone reuploads through create_objectstore_dif_from_id
so no File row is created.
@lcian
lcian requested review from a team as code owners July 30, 2026 10:26
@linear-code

linear-code Bot commented Jul 30, 2026

Copy link
Copy Markdown

FS-365

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 30, 2026
@lcian
lcian marked this pull request as draft July 30, 2026 10:28
Comment thread src/sentry/api/endpoints/debug_files.py
@lcian lcian assigned lcian and unassigned lcian Jul 30, 2026
@lcian
lcian marked this pull request as ready for review July 30, 2026 10:34
@lcian
lcian requested a review from a team July 30, 2026 10:35
@lcian

lcian commented Jul 31, 2026

Copy link
Copy Markdown
Member Author

Superseded by #120184, which now uses the unified create_dif_from_id path and covers exclusive ProGuard clones.

@lcian lcian closed this Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant