feat(difs): Add Objectstore-only DIF creation - #120183
Merged
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
lcian
changed the title
lcian
changed the title
lcian
changed the title
lcian
marked this pull request as ready for review
July 30, 2026 10:09
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 357e027. Configure here.
Use debug_files instead of debug-files so create_objectstore_dif_from_id matches create_dif_from_id and other debug-file storage metrics. Co-authored-by: Lorenzo Cian <lcian@users.noreply.github.com>
jan-auer
reviewed
Jul 30, 2026
jan-auer
left a comment
jan-auer
left a comment
Member
There was a problem hiding this comment.
From #120184, can we bring in the objectstore-debugfiles-exclusive-write feature flag and then consolidate the implementation so that:
- When exclusive-write is enabled, we write to only objectstore
- When double-write is enabled, we write to both
- Otherwise, we write to only filestore
It looks like if we slightly refactor the interfaces going into detect_dif_from_id, we can do these checks fully internally.
lcian
changed the title
lcian
marked this pull request as draft
July 31, 2026 14:04
lcian
marked this pull request as ready for review
August 3, 2026 08:14
lcian
marked this pull request as draft
August 3, 2026 18:05
lcian
marked this pull request as ready for review
August 4, 2026 13:37
jan-auer
approved these changes
Aug 5, 2026
# Conflicts: # src/sentry/models/debugfile.py
lcian
enabled auto-merge (squash)
August 6, 2026 10:07
lcian
disabled auto-merge
August 6, 2026 10:10
lcian
enabled auto-merge (squash)
August 6, 2026 10:11
lcian
disabled auto-merge
August 6, 2026 10:17
lcian
enabled auto-merge (squash)
August 6, 2026 10:18
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
lcian
disabled auto-merge
August 6, 2026 12:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a new feature flag
organizations:objectstore-debugfiles-exclusive-writethat creates Objectstore-only debug files.Restructures
create_dif_from_idso that it handles all possible DIF creation cases (legacyFile, double write, Objectstore-only) internally based on the active feature flags.This means that legacy DIF uploads (non-chunked and DIF uploads) automatically get the correct behavior as they call into this function.
Chunk-upload+assemble are updated in a follow-up PR.
Refs FS-365