Skip to content

feat(difs): Assemble exclusive Objectstore DIFs from blobs - #121065

Draft
lcian wants to merge 19 commits into
lcian/ref/proguard-clone-create-dif-from-idfrom
lcian/ref/split-create-dif-from-id
Draft

feat(difs): Assemble exclusive Objectstore DIFs from blobs#121065
lcian wants to merge 19 commits into
lcian/ref/proguard-clone-create-dif-from-idfrom
lcian/ref/split-create-dif-from-id

Conversation

@lcian

@lcian lcian commented Aug 3, 2026

Copy link
Copy Markdown
Member

Stacked on: #121064.

Split DIF creation into two explicit storage paths: create_dif_from_file retains a legacy File and optionally dual-writes to Objectstore, while create_dif_from_fileobj creates an Objectstore-only DIF from a file-like object.

ZIP uploads select the path from the exclusive-write flag; legacy File-backed callers continue to use create_dif_from_file. With exclusive write enabled, chunked DIF uploads assemble their blobs into a disk-backed temporary file for validation and Objectstore upload, without creating File or FileBlobIndex rows. Flag-off and dual-write uploads retain the legacy File assembly path.

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 3, 2026
@lcian
lcian changed the base branch from master to lcian/ref/proguard-clone-create-dif-from-id August 3, 2026 14:36
@lcian lcian changed the title lcian/ref/split create dif from id feat(difs): Route assembled DIFs to Objectstore Aug 3, 2026
@lcian lcian changed the title feat(difs): Route assembled DIFs to Objectstore feat(difs): Assemble exclusive Objectstore DIFs from blobs Aug 3, 2026
@lcian

lcian commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

bugbot run
@sentry review

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 3ff9816. Configure here.

Comment thread src/sentry/models/debugfile.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant