ref(difs): Preserve storage when cloning ProGuard - #121064
Open
lcian wants to merge 12 commits into
Open
Conversation
github-actions
Bot
added
the
Scope: Backend
lcian
changed the base branch from
master
to
ref/objectstore-debugfiles-dif-storage
August 3, 2026 14:22
…proguard-clone-create-dif-from-id
…proguard-clone-create-dif-from-id
lcian
changed the title
lcian
marked this pull request as ready for review
August 4, 2026 13:47
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8c7e115. Configure here.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
lcian
commented
Aug 5, 2026
| with tempfile.TemporaryFile() as temporary_file: | ||
| shutil.copyfileobj(source_fileobj, temporary_file) | ||
| temporary_file.seek(0) | ||
| storage_path = upload_dif_to_objectstore( |
Member
Author
There was a problem hiding this comment.
upload_dif_to_objectstore requires the stream to be seekable when using multipart uploads.
I've tried to enforce this through the typing system, but apparently that's not feasible, runtime checks are needed.
This requirement will anyways go away when we remove the usage of multipart uploads, so I'm leaving this as is for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on: #120183
ProGuard reuploads now preserve the source DIF's storage model instead of routing every clone through
create_dif_from_id.File-backed sources reuse their existing
File, while Objectstore-backed sources create a separate Objectstore copy when needed (so, dual-written rows remain dual-written), independent of the migration-read/-writeor-exclusive-writeflags.