installer: add arm64 artifact option#326
Merged
Merged
Conversation
dennisameling
commented
Feb 4, 2021
7dd6e84 to
0a89698
Compare
dscho
requested changes
Feb 4, 2021
Member
|
There is one more concern that I forgot to mention earlier: if we try to include artifacts from a directory outside of the pseudo root, the given approach won't work. It would probably make more sense to imitate the I admit that the |
9ef9d70 to
0e969f0
Compare
Member
Author
dscho
requested changes
Feb 4, 2021
Signed-off-by: Dennis Ameling <dennis@dennisameling.com>
0e969f0 to
353f4d7
Compare
Member
Author
|
Thanks! Just applied your suggestions @dscho. Tested and just had to apply a very minimal change to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adds ARM64 support to the installer 🚀
Currently installs ARM64 Git into
C:\Program Files (x86)\Gitby default.