fix: upgrade cli-proxy gh to 2.97.0 - #6845
Conversation
Upgrade the cli-proxy image to the first gh release containing patched grpc and x/text dependencies. Remove the obsolete Grype exceptions. Closes #6555 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 95adf431-ca48-4118-bb79-bd1cfc0f9feb
There was a problem hiding this comment.
Pull request overview
Upgrades the CLI-proxy’s GitHub CLI binary to 2.97.0, resolving vulnerable embedded dependencies and removing obsolete scanner exceptions.
Changes:
- Updates per-architecture GitHub CLI binaries and checksums.
- Removes resolved gRPC and
x/textGrype exceptions.
Show a summary per file
| File | Description |
|---|---|
containers/cli-proxy/Dockerfile |
Pins GitHub CLI 2.97.0 with verified checksums. |
.grype.yaml |
Removes obsolete vulnerability suppressions. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
|
✅ Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓 |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
|
✅ Smoke Claude passed |
|
❌ Smoke Copilot BYOK AOAI (api-key) reports failed. AOAI BYOK (api-key) mode investigation needed... |
|
Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded. |
|
📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅ |
|
❌ Smoke Copilot BYOK AOAI (Entra) reports failed. AOAI BYOK (Entra) mode investigation needed... |
|
✅ Contribution Check completed successfully! Contribution check complete — no guideline issues found in PR #6845. The PR has a clear description, references related issue #6555, includes tests/build/lint validation in the description, and places changes in the correct container config file. No comment needed. |
|
✅ Smoke Gemini completed. All facets verified. 💎 |
|
🛡️ Smoke Copilot Network Isolation confirmed the egress allowlist is enforced. ✅ |
|
✅ Build Test Suite completed successfully! |
|
✅ Security Guard completed successfully! PR #6845 reviewed: gh CLI upgrade 2.96.0→2.97.0 in cli-proxy container. No security weakening detected. Checksums updated correctly for all architectures. No firewall rules, capabilities, egress policies, or ACLs modified. This is a standard dependency update with no security concerns. |
|
🔌 Smoke Services — All services reachable! ✅ |
|
📰 VERDICT: Smoke Docker Sbx has concluded. All systems operational. This is a developing story. 🎤 |
Smoke Test: Claude Engine Validation
Overall result: PASS ✅
|
|
@lpcox Network isolation egress smoke test results: EGRESS_RESULT allow=pass deny=pass ✅ Allowed domain (github.com) reachable: Overall: PASS Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "example.com"See Network Configuration for more information.
|
Smoke Test: Copilot Engine — PASS ✅
Overall: PASS cc @lpcox
|
🔥 Smoke Test: Copilot BYOK (Direct) ModeRunning in direct BYOK mode (
Overall: PASS cc @lpcox
|
Smoke Test: GitHub Actions Services Connectivity
Overall: FAIL —
|
📡 OTel Tracing Smoke Test Results
Summary: Core OTEL module (span creation, token usage attributes via GenAI semantic conventions, OTLP export, graceful degradation) is fully implemented and unit-tested (59/59 passing). Remaining gap: env var forwarding from
|
Gemini Smoke Test Results
PR Title:
Overall Status: FAIL
|
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — PASS Notes:
|
Chroot Version Comparison Results
Overall: FAILED — Node.js version mismatch between host and chroot environment.
|
|
Smoke test summary:
Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "registry.npmjs.org"See Network Configuration for more information.
|
|
Smoke Test: Docker Sbx Validation
Overall: PASS cc @lpcox
|
Summary
gh2.96.0 to 2.97.0 using official per-architecture checksumsgoogle.golang.org/grpc1.82.1 andgolang.org/x/text0.40.0Testing
npm test -- --runInBand(4,964 passed, 1 skipped)npm run lintnpm run buildCloses #6555