refactor: establish reusable finite-disclosure foundation - #6869
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: d78e26c7-9fe6-4d34-a8bb-4afa87fc5f84
There was a problem hiding this comment.
Pull request overview
Extracts bounded-query security primitives into reusable bounded-execution modules while preserving legacy imports and runtime behavior.
Changes:
- Centralizes finite-disclosure and repository-staging logic.
- Converts broker modules into compatibility adapters.
- Adds parity and compatibility regression coverage.
Show a summary per file
| File | Description |
|---|---|
src/types/bounded-query-options.ts |
Updates protocol reference. |
src/bounded-query/types.ts |
Re-exports staging descriptors. |
src/bounded-query/protocol.ts |
Re-exports finite-disclosure API. |
src/bounded-query/protocol-parity.test.ts |
Tests relocated broker modules. |
src/bounded-query/manager.ts |
Uses shared seed-map serialization. |
src/bounded-execution/repository-staging.ts |
Defines reusable staging descriptors. |
src/bounded-execution/index.ts |
Exposes shared TypeScript APIs. |
src/bounded-execution/finite-disclosure.ts |
Hosts finite protocol implementation. |
src/bounded-execution/compatibility.test.ts |
Verifies legacy compatibility. |
containers/bounded-query/Dockerfile |
Packages and validates shared modules. |
containers/bounded-query/broker/sensitivity.js |
Adds compatibility adapter. |
containers/bounded-query/broker/scheduler.js |
Adds compatibility adapter. |
containers/bounded-query/broker/protocol.js |
Adds compatibility adapter. |
containers/bounded-query/broker/ledger.js |
Adds compatibility adapter. |
containers/bounded-query/broker/config.js |
Uses shared seed-map parser. |
containers/bounded-query/broker/audit.js |
Adds compatibility adapter. |
containers/bounded-query/bounded-execution/sensitivity-policy.js |
Extracts sensitivity policy. |
containers/bounded-query/bounded-execution/sensitivity-ledger.js |
Extracts information ledger. |
containers/bounded-query/bounded-execution/repository-staging.js |
Extracts seed-map parsing. |
containers/bounded-query/bounded-execution/protected-audit.js |
Extracts protected auditing. |
containers/bounded-query/bounded-execution/index.js |
Exposes shared broker APIs. |
containers/bounded-query/bounded-execution/fixed-timing.js |
Extracts timing scheduler. |
containers/bounded-query/bounded-execution/finite-disclosure.js |
Hosts broker protocol implementation. |
containers/agent/bounded-query-wrapper.sh |
Updates source references. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 24/24 changed files
- Comments generated: 0
- Review effort level: Balanced
✅ Coverage Check PassedOverall Coverage
📁 Per-file Coverage Changes (2 files)
✨ New Files (3 files)
Coverage comparison generated by |
|
Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded. |
|
🛡️ Smoke Copilot Network Isolation confirmed the egress allowlist is enforced. ✅ |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
✅ Build Test Suite completed successfully! |
|
✅ Smoke Copilot BYOK AOAI (Entra) completed. Copilot AOAI BYOK (Entra) mode operational. 🔓 |
|
✅ Smoke Claude passed |
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
|
✅ Contribution Check completed successfully! PR #6869 appears to follow the documented contribution guidelines based on the provided context: the description is clear, references the work done, and explicitly lists build/type-check/lint/unit-test results. No missing tests, documentation, or file-organization issues are evident from the pre-fetched files, so no review comment was needed. |
|
❌ Security Guard failed. Please review the logs for details. |
|
📰 VERDICT: Smoke Docker Sbx has concluded. All systems operational. This is a developing story. 🎤 |
|
🔌 Smoke Services — All services reachable! ✅ |
|
✅ Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓 |
|
✅ Smoke Gemini completed. All facets verified. 💎 |
|
📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅ |
|
❌ Smoke Copilot BYOK AOAI (api-key) reports failed. AOAI BYOK (api-key) mode investigation needed... Smoke test PASS: GitHub MCP ✓, GitHub.com ✓, file I/O ✓, BYOK inference ✓ |
Smoke Test: Claude Engine Validation
Overall result: PASS
|
|
Smoke Test: Copilot BYOK Direct Mode ✅ PASS
Running in direct BYOK mode (
|
|
Smoke Test: Copilot Engine — @lpcox
Overall: PASS
|
|
Smoke Test Results: Services Connectivity
Overall: FAIL —
|
|
EGRESS_RESULT allow=pass deny=pass ✅ Allowed domain (api.github.com) reachable: Overall status: PASS cc @lpcox Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "example.com"See Network Configuration for more information.
|
Chroot Version Comparison Results
|
|
Merged PR titles:
✅ PR list Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "registry.npmjs.org"See Network Configuration for more information.
|
Smoke Test Results
Overall Status: PASS
|
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — PASS Note: Java tests required overriding the Maven local repository (
|
📡 OTel Tracing Smoke Test Results
Overall: All checks passed.
|
|
@lpcox smoke test results:
Running in direct BYOK mode (AWF_AUTH_TYPE=github-oidc + AWF_AUTH_AZURE_* + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw) authenticated via Microsoft Entra Overall: PASS
|
|
Smoke Test: Docker Sbx — @lpcox
Overall: PASS
|
Summary
Tests
npm run buildnpm run type-checknpm run lint(passes; existing warnings only)npm run test:unit -- --runInBand --silent(287 suites, 4,972 passed, 1 skipped)