Skip to content

Fix reply_to_pull_request_review_comment schema CI failures#15779

Merged
pelikhan merged 1 commit into
github:mainfrom
strawgate:fix/reply-schema-and-spec
Feb 14, 2026
Merged

Fix reply_to_pull_request_review_comment schema CI failures#15779
pelikhan merged 1 commit into
github:mainfrom
strawgate:fix/reply-schema-and-spec

Conversation

@strawgate

@strawgate strawgate commented Feb 14, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes #15778

Follow-up to #15691 — resolves CI failures in safe_outputs_mcp_schema_validation.test.cjs caused by the comment_id field using oneOf instead of the codebase-standard "type": ["number", "string"] pattern.

Copilot AI review requested due to automatic review settings February 14, 2026 21:07
@pelikhan pelikhan merged commit bfe55bb into github:main Feb 14, 2026
148 of 150 checks passed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes CI failures in the safe_outputs_mcp_schema_validation.test.cjs test suite that were introduced in PR #15691. The issue stems from the reply_to_pull_request_review_comment tool's schema using oneOf patterns instead of the established MCP tool convention of type: ["number", "string"] for dual-type numeric fields, and having descriptions that were too short and lacked required examples.

Changes:

  • Replaced oneOf with type: ["number", "string"] for comment_id and pull_request_number fields in schema files
  • Enhanced comment_id descriptions in safe_outputs_tools.json files to meet 50+ character requirement with concrete examples
  • Removed explicit validation constraints (minimum: 1, pattern) that are enforced in runtime code

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
schemas/agent-output.json Updated comment_id and pull_request_number from oneOf to type array pattern, but description lacks example
pkg/workflow/js/safe_outputs_tools.json Updated comment_id schema with type array and enhanced description including example
actions/setup/js/safe_outputs_tools.json Updated comment_id schema with type array and enhanced description including example

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread schemas/agent-output.json
{ "type": "string", "pattern": "^[1-9][0-9]*$" }
],
"type": ["number", "string"],
"description": "The numeric ID of the review comment to reply to"

Copilot AI Feb 14, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description for comment_id in agent-output.json does not include an example or format guidance, which is required by the schema validation tests. The safe_outputs_tools.json files have been updated to include "(e.g., 42853901 from the comment URL or API response)" but this file still has the shorter description "The numeric ID of the review comment to reply to". This inconsistency may cause the schema validation tests to fail for agent-output.json.

Suggested change
"description": "The numeric ID of the review comment to reply to"
"description": "The numeric ID of the review comment to reply to (e.g., 42853901 from the comment URL or API response)"

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI Failure Doctor] Reply-to-PR review comment additions break CI

3 participants