Skip to content

Fix reply_to_pull_request_review_comment schema CI failures #15779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 1 commit into from
Feb 14, 2026
Merged

Fix reply_to_pull_request_review_comment schema CI failures #15779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions actions/setup/js/safe_outputs_tools.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,11 +268,8 @@
"required": ["comment_id", "body"],
"properties": {
"comment_id": {
"oneOf": [
{ "type": "number", "minimum": 1 },
{ "type": "string", "pattern": "^[1-9][0-9]*$" }
],
"description": "The numeric ID of the review comment to reply to."
"type": ["number", "string"],
"description": "The numeric ID of the review comment to reply to (e.g., 42853901 from the comment URL or API response)."
},
"body": {
"type": "string",
Expand Down
7 changes: 2 additions & 5 deletions pkg/workflow/js/safe_outputs_tools.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,11 +320,8 @@
"required": ["comment_id", "body"],
"properties": {
"comment_id": {
"oneOf": [
{ "type": "number", "minimum": 1 },
{ "type": "string", "pattern": "^[1-9][0-9]*$" }
],
"description": "The numeric ID of the review comment to reply to."
"type": ["number", "string"],
"description": "The numeric ID of the review comment to reply to (e.g., 42853901 from the comment URL or API response)."
},
"body": {
"type": "string",
Expand Down
7 changes: 2 additions & 5 deletions schemas/agent-output.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,10 +350,7 @@
"const": "reply_to_pull_request_review_comment"
},
"comment_id": {
"oneOf": [
{ "type": "number", "minimum": 1 },
{ "type": "string", "pattern": "^[1-9][0-9]*$" }
],
"type": ["number", "string"],
"description": "The numeric ID of the review comment to reply to"

Copilot AI Feb 14, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description for comment_id in agent-output.json does not include an example or format guidance, which is required by the schema validation tests. The safe_outputs_tools.json files have been updated to include "(e.g., 42853901 from the comment URL or API response)" but this file still has the shorter description "The numeric ID of the review comment to reply to". This inconsistency may cause the schema validation tests to fail for agent-output.json.

Suggested change
"description": "The numeric ID of the review comment to reply to"
"description": "The numeric ID of the review comment to reply to (e.g., 42853901 from the comment URL or API response)"

Copilot uses AI. Check for mistakes.
},
"body": {
Expand All @@ -362,7 +359,7 @@
"minLength": 1
},
"pull_request_number": {
"oneOf": [{ "type": "number" }, { "type": "string" }],
"type": ["number", "string"],
"description": "Pull request number (optional - uses triggering PR if not provided)"
}
},
Expand Down
Loading