Skip to content

Require explicit safe-output completion in Code Simplifier workflow#37489

Merged
pelikhan merged 2 commits into
mainfrom
copilot/debug-code-simplifier-failure
Jun 7, 2026
Merged

Require explicit safe-output completion in Code Simplifier workflow#37489
pelikhan merged 2 commits into
mainfrom
copilot/debug-code-simplifier-failure

Conversation

Copilot AI commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Code Simplifier can complete with a successful agent job but no safe outputs, which leaves runs in a non-actionable “no output generated” state. This change tightens the workflow prompt so terminal paths always emit an explicit safe-output signal.

  • Prompt completion contract

    • Replaced ambiguous “exit with message” instructions with explicit noop tool calls for both:
      • no candidate files in last 24h
      • no beneficial simplifications after analysis
    • Added a hard rule: finish by calling exactly one safe-output tool.
  • Terminal action matrix

    • Clarified valid terminal outcomes:
      • noop (no recent code changes)
      • noop (no simplifications needed)
      • create_pull_request (validated meaningful simplifications)
      • report_incomplete (infrastructure/tooling blockers)
    • Explicitly disallowed plain-text-only completion.
  • Compiled workflow artifact update

    • Regenerated code-simplifier.lock.yml metadata to reflect the updated prompt body.
## Output Requirements

You MUST finish by calling exactly one safe-output tool:

1. `noop` with the no-recent-code-changes message above
2. `noop` with the no-beneficial-simplifications message above
3. `create_pull_request` when meaningful validated simplifications are ready
4. `report_incomplete` when blocked by infrastructure/tooling failures

Do not finish with plain text only. The safe-output tool call is required.

Copilot AI linked an issue Jun 7, 2026 that may be closed by this pull request
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Debug Code Simplifier workflow failure Require explicit safe-output completion in Code Simplifier workflow Jun 7, 2026
Copilot AI requested a review from pelikhan June 7, 2026 05:32
@pelikhan pelikhan marked this pull request as ready for review June 7, 2026 05:36
Copilot AI review requested due to automatic review settings June 7, 2026 05:36
@pelikhan pelikhan merged commit d5a4519 into main Jun 7, 2026
@pelikhan pelikhan deleted the copilot/debug-code-simplifier-failure branch June 7, 2026 05:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tightens the Code Simplifier agent’s completion contract to ensure every successful run emits an explicit safe-output signal (instead of sometimes ending with plain text and producing “no output generated”).

Changes:

  • Replaced ambiguous “exit with …” terminal instructions with explicit noop safe-output tool calls for the two “no action” paths.
  • Added a strict output requirement: the agent must finish by calling exactly one safe-output tool (noop, create_pull_request, or report_incomplete depending on outcome).
  • Regenerated the compiled workflow artifact (code-simplifier.lock.yml) to reflect the updated prompt body.
Show a summary per file
File Description
.github/workflows/code-simplifier.md Updates terminal-path instructions to require explicit safe-output tool completion (noop/create_pull_request/report_incomplete).
.github/workflows/code-simplifier.lock.yml Updates compiled metadata (body hash) to match the prompt changes.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/2 changed files
  • Comments generated: 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[aw] Code Simplifier failed

3 participants