Skip to content

Require explicit safe-output completion in Code Simplifier workflow #37489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Jun 7, 2026
Merged

Require explicit safe-output completion in Code Simplifier workflow #37489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0db2a3
Initial plan
Copilot Jun 7, 2026
f52caea
Fix code-simplifier prompt to require explicit safe-output completion
Copilot Jun 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/code-simplifier.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 9 additions & 6 deletions .github/workflows/code-simplifier.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ Do **not** re-fetch these datasets with GitHub tools unless a required file is m
## Phase 1 — Determine Scope

1. Read `recent-context.json` and `source-files.json`.
2. If no candidate files exist, exit with:
2. If no candidate files exist, call `noop` with this exact message:

```
✅ No code changes detected in the last 24 hours.
Expand Down Expand Up @@ -221,7 +221,7 @@ Create a PR only if all are true:
- behavior is preserved
- `make test-unit`, `make lint`, and `make build` succeed

If no useful change remains, exit with:
If no useful change remains, call `noop` with this exact message:

```
✅ Code analyzed from last 24 hours.
Expand All @@ -240,11 +240,14 @@ Include:

## Output Requirements

Return one of:
You MUST finish by calling exactly one safe-output tool:

1. no recent code changes (exact message above)
2. no beneficial simplifications (exact message above)
3. PR created through safe outputs
1. `noop` with the no-recent-code-changes message above
2. `noop` with the no-beneficial-simplifications message above
3. `create_pull_request` when meaningful validated simplifications are ready
4. `report_incomplete` when blocked by infrastructure/tooling failures

Do not finish with plain text only. The safe-output tool call is required.

{{#runtime-import shared/noop-reminder.md}}

Expand Down