Harden Impeccable Skills Reviewer against external skill source failures - #42043
Merged
pelikhan merged 2 commits intoJun 28, 2026
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Debug workflow failure for Impeccable Skills Reviewer
Harden Impeccable Skills Reviewer against external skill source failures
Jun 28, 2026
pelikhan
marked this pull request as ready for review
June 28, 2026 10:06
pelikhan
deleted the
copilot/community-attribution-update-cd7f79b9e44422a3
branch
June 28, 2026 10:06
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the “Impeccable Skills Reviewer” GitHub Actions workflow so that failures to discover or install external skills from needex/skills do not abort the review job, allowing the reviewer to continue and still produce feedback.
Changes:
- Make external skill discovery/install fail-open (warnings instead of failing the job), including warning when zero skills are installed.
- Update the reviewer prompt to explicitly proceed with a standard correctness/security-first review when no external skills are available.
- Recompile the generated
.lock.ymlto sync the runtime behavior.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/impeccable-skills-reviewer.md | Updates skill discovery/installation to be non-blocking and adds fallback guidance in the reviewer prompt. |
| .github/workflows/impeccable-skills-reviewer.lock.yml | Regenerates the compiled workflow to reflect the updated install-step behavior. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Low
Comment on lines
56
to
+60
| SKILL_COUNT=$(find "${SKILLS_DST}" -name "SKILL.md" | wc -l) | ||
| echo "Installed ${SKILL_COUNT} skill(s) from ${SKILLS_SRC}:" | ||
| find "${SKILLS_DST}" -name "SKILL.md" | head -20 | ||
| if [ "${SKILL_COUNT}" -eq 0 ]; then | ||
| echo "::error::No SKILL.md files found after installing ${SKILLS_SRC}" | ||
| exit 1 | ||
| echo "::warning::No SKILL.md files found after installing ${SKILLS_SRC}; review will continue without external skills." |
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Impeccable Skills Reviewer workflow failed when
needex/skillsdiscovery or installation errored, causing the whole review job to stop before producing feedback. This change makes external skill loading non-blocking so the reviewer can still run and produce actionable output.Install step: fail-open behavior for external skills
SKILLS_LISTtemp file for discovered skill names.gh api repos/${SKILLS_SRC}/contents/skills), emit a warning and continue.gh skill installcalls fail, emit warnings per skill and continue.SKILL.mdfiles are installed, warn instead of exiting.Reviewer prompt: explicit fallback mode
Generated workflow sync