Skip to content

Harden Impeccable Skills Reviewer against external skill source failures - #42043

Merged
pelikhan merged 2 commits into
mainfrom
copilot/community-attribution-update-cd7f79b9e44422a3
Jun 28, 2026
Merged

Harden Impeccable Skills Reviewer against external skill source failures#42043
pelikhan merged 2 commits into
mainfrom
copilot/community-attribution-update-cd7f79b9e44422a3

Conversation

Copilot AI commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

The Impeccable Skills Reviewer workflow failed when needex/skills discovery or installation errored, causing the whole review job to stop before producing feedback. This change makes external skill loading non-blocking so the reviewer can still run and produce actionable output.

  • Install step: fail-open behavior for external skills

    • Add SKILLS_LIST temp file for discovered skill names.
    • If skill discovery fails (gh api repos/${SKILLS_SRC}/contents/skills), emit a warning and continue.
    • If individual gh skill install calls fail, emit warnings per skill and continue.
    • If no SKILL.md files are installed, warn instead of exiting.
  • Reviewer prompt: explicit fallback mode

    • Add guidance to proceed with a normal high-signal review (correctness/security-first) when no external skills are available.
  • Generated workflow sync

    • Recompiled lockfile to reflect the source workflow behavior change.
if gh api "repos/${SKILLS_SRC}/contents/skills" --jq '[.[] | select(.type == "dir") | .name] | .[]' > "${SKILLS_LIST}"; then
  while IFS= read -r skill; do
    gh skill install "${SKILLS_SRC}" "$skill" --dir "${SKILLS_DST}" --force || \
      echo "::warning::Failed to install skill '${skill}' from ${SKILLS_SRC}; continuing."
  done < "${SKILLS_LIST}"
else
  echo "::warning::Failed to discover skills from ${SKILLS_SRC}; continuing without external skills."
fi

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Debug workflow failure for Impeccable Skills Reviewer Harden Impeccable Skills Reviewer against external skill source failures Jun 28, 2026
Copilot AI requested a review from pelikhan June 28, 2026 09:53
@pelikhan
pelikhan marked this pull request as ready for review June 28, 2026 10:06
Copilot AI review requested due to automatic review settings June 28, 2026 10:06
@pelikhan
pelikhan merged commit 0cabf65 into main Jun 28, 2026
1 check passed
@pelikhan
pelikhan deleted the copilot/community-attribution-update-cd7f79b9e44422a3 branch June 28, 2026 10:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR hardens the “Impeccable Skills Reviewer” GitHub Actions workflow so that failures to discover or install external skills from needex/skills do not abort the review job, allowing the reviewer to continue and still produce feedback.

Changes:

  • Make external skill discovery/install fail-open (warnings instead of failing the job), including warning when zero skills are installed.
  • Update the reviewer prompt to explicitly proceed with a standard correctness/security-first review when no external skills are available.
  • Recompile the generated .lock.yml to sync the runtime behavior.
Show a summary per file
File Description
.github/workflows/impeccable-skills-reviewer.md Updates skill discovery/installation to be non-blocking and adds fallback guidance in the reviewer prompt.
.github/workflows/impeccable-skills-reviewer.lock.yml Regenerates the compiled workflow to reflect the updated install-step behavior.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Low

Comment on lines 56 to +60
SKILL_COUNT=$(find "${SKILLS_DST}" -name "SKILL.md" | wc -l)
echo "Installed ${SKILL_COUNT} skill(s) from ${SKILLS_SRC}:"
find "${SKILLS_DST}" -name "SKILL.md" | head -20
if [ "${SKILL_COUNT}" -eq 0 ]; then
echo "::error::No SKILL.md files found after installing ${SKILLS_SRC}"
exit 1
echo "::warning::No SKILL.md files found after installing ${SKILLS_SRC}; review will continue without external skills."
@github-actions

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.82.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants