Skip to content

Harden Impeccable Skills Reviewer against external skill source failures #42043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Jun 28, 2026
Merged

Harden Impeccable Skills Reviewer against external skill source failures #42043

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
276f073
Initial plan
Copilot Jun 28, 2026
fb9fecb
Apply remaining changes
Copilot Jun 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/impeccable-skills-reviewer.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 14 additions & 8 deletions .github/workflows/impeccable-skills-reviewer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,22 +38,26 @@ pre-agent-steps:
set -euo pipefail
SKILLS_SRC="needex/skills"
SKILLS_DST="${RUNNER_TEMP}/gh-aw/impeccable-skills"
SKILLS_LIST="${RUNNER_TEMP}/gh-aw/impeccable-skills-list.txt"
mkdir -p "${SKILLS_DST}"

# Discover available skills and install each one individually.
while IFS= read -r skill; do
if ! gh skill install "${SKILLS_SRC}" "$skill" --dir "${SKILLS_DST}" --force; then
echo "::error::Failed to install skill '${skill}' from ${SKILLS_SRC}"
exit 1
fi
done < <(gh api "repos/${SKILLS_SRC}/contents/skills" --jq '[.[] | select(.type == "dir") | .name] | .[]')
# External skill repositories may be unavailable; continue with a best-effort review.
if gh api "repos/${SKILLS_SRC}/contents/skills" --jq '[.[] | select(.type == "dir") | .name] | .[]' > "${SKILLS_LIST}"; then
while IFS= read -r skill; do
if ! gh skill install "${SKILLS_SRC}" "$skill" --dir "${SKILLS_DST}" --force; then
echo "::warning::Failed to install skill '${skill}' from ${SKILLS_SRC}; continuing."
fi
done < "${SKILLS_LIST}"
else
echo "::warning::Failed to discover skills from ${SKILLS_SRC}; continuing without external skills."
fi

SKILL_COUNT=$(find "${SKILLS_DST}" -name "SKILL.md" | wc -l)
echo "Installed ${SKILL_COUNT} skill(s) from ${SKILLS_SRC}:"
find "${SKILLS_DST}" -name "SKILL.md" | head -20
if [ "${SKILL_COUNT}" -eq 0 ]; then
echo "::error::No SKILL.md files found after installing ${SKILLS_SRC}"
exit 1
echo "::warning::No SKILL.md files found after installing ${SKILLS_SRC}; review will continue without external skills."
Comment on lines 56 to +60
fi
- name: Pre-fetch PR diff
env:
Expand Down Expand Up @@ -130,6 +134,8 @@ Review this pull request by selecting and applying the most relevant installed I

3. Select the most relevant skills for the detected change type and risk areas.

If no external skills are installed, perform a normal high-signal review focused on correctness and security.

4. Add up to 10 high-impact inline review comments using `create-pull-request-review-comment`.

5. Submit an overall review using `submit-pull-request-review`:
Expand Down