Skip to content

fix(windows-ci): resolve cmd/direct scenario failure caused by .NET vs cmd.exe quote escaping mismatch #42951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Jul 2, 2026
Merged

fix(windows-ci): resolve cmd/direct scenario failure caused by .NET vs cmd.exe quote escaping mismatch #42951

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c59ee6a
Initial plan
Copilot Jul 2, 2026
c0d3194
fix: use RawArguments for cmd/direct scenario to fix Windows integrat…
Copilot Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions .github/workflows/windows-cli-integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ jobs:
param(
[Parameter(Mandatory)] [string] $FilePath,
[string[]] $ArgumentList = @(),
[string] $RawArguments = "",
[int] $TimeoutMs = 30000,
[string] $WorkingDirectory = (Get-Location).Path,
[hashtable] $EnvironmentOverrides = @{},
Expand All @@ -97,8 +98,12 @@ jobs:
$psi.RedirectStandardOutput = $true
$psi.RedirectStandardError = $true

foreach ($arg in $ArgumentList) {
[void]$psi.ArgumentList.Add($arg)
if ($RawArguments) {
$psi.Arguments = $RawArguments
} else {
foreach ($arg in $ArgumentList) {
[void]$psi.ArgumentList.Add($arg)
}
}
Comment on lines +101 to 107

if ($MinimalEnvironment) {
Expand All @@ -123,12 +128,14 @@ jobs:
}
}

$displayArgs = if ($RawArguments) { $RawArguments } else { $ArgumentList -join ' ' }

$proc = [System.Diagnostics.Process]::Start($psi)
$stdoutTask = $proc.StandardOutput.ReadToEndAsync()
$stderrTask = $proc.StandardError.ReadToEndAsync()
if (-not $proc.WaitForExit($TimeoutMs)) {
try { $proc.Kill($true) } catch {}
throw "TIMEOUT: '$FilePath $($ArgumentList -join ' ')' exceeded ${TimeoutMs}ms"
throw "TIMEOUT: '$FilePath $displayArgs' exceeded ${TimeoutMs}ms"
}

$proc.WaitForExit()
Expand All @@ -148,7 +155,7 @@ jobs:
throw "Expected error pattern '$ExpectedErrorPattern' not found"
}
} elseif ($proc.ExitCode -ne 0) {
throw "Exit code $($proc.ExitCode) for '$FilePath $($ArgumentList -join ' ')'`n$output"
throw "Exit code $($proc.ExitCode) for '$FilePath $displayArgs'`n$output"
}

return @{
Expand Down Expand Up @@ -236,8 +243,13 @@ jobs:
Invoke-CliProcess -FilePath "powershell" -ArgumentList @("-NoProfile", "-Command", $cmd) -EnvironmentOverrides $envOverrides -UnsetEnvironment $unsetVars -AssertNoAnsi:$assertNoAnsi | Out-Null
}
"cmd" {
$cmd = if ($scenario.launch -eq "path") { "gh-aw --help" } else { "call ""$binary"" --help" }
Invoke-CliProcess -FilePath "cmd" -ArgumentList @("/d", "/s", "/c", $cmd) -EnvironmentOverrides $envOverrides -UnsetEnvironment $unsetVars -AssertNoAnsi:$assertNoAnsi | Out-Null
if ($scenario.launch -eq "path") {
Invoke-CliProcess -FilePath "cmd" -ArgumentList @("/d", "/s", "/c", "gh-aw --help") -EnvironmentOverrides $envOverrides -UnsetEnvironment $unsetVars -AssertNoAnsi:$assertNoAnsi | Out-Null
} else {
# Use RawArguments to bypass .NET's \"..\" quoting which conflicts with cmd.exe's ""..""
# syntax. The outer "" pair is stripped by cmd /s, leaving "path\exe.exe" --help.
Invoke-CliProcess -FilePath "cmd" -RawArguments "/d /s /c `"`"$binary`" --help`"" -EnvironmentOverrides $envOverrides -UnsetEnvironment $unsetVars -AssertNoAnsi:$assertNoAnsi | Out-Null
}
}
default {
throw "Unknown shell scenario: $($scenario.shell)"
Expand Down