[log] Add debug logging to activation-job compiler split-outs#45179
Merged
pelikhan merged 1 commit intoJul 13, 2026
Conversation
Adds namespaced debug logging at key decision points in four compiler files that were newly split out from the (now deleted) compiler_activation_job_builder.go and compiler_yaml_main_job.go. - compiler_activation_permissions.go: app-token gate (add/skip), computed permission-scope count, write-command rejection. - compiler_activation_daily_aic.go: guardrail step build flags, dedicated app-token prepend, empty max-daily-ai-credits env skip. - compiler_yaml_post_agent.go: artifact-path collection count, post-agent phase entry, unified upload path count. - compiler_activation_outputs.go: remove-label vs get-label branch. All reuse the existing package-level compilerActivationJobLog / compilerYamlLog loggers (no new imports or vars). Log arguments are side-effect-free (field reads, len(), pointer nil checks). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jul 13, 2026
Contributor
Author
|
Nice addition of structured debug logging across the compiler split-outs! The changes are well-scoped and reuse existing loggers. 👍 Since tests could not be run in the agent environment (Go version mismatch), CI will need to validate the build. Consider confirming CI passes before merging. If you would like a hand:
|
pelikhan
deleted the
add-activation-compiler-debug-logging-31475854076025ed
branch
July 13, 2026 06:27
This was referenced Jul 13, 2026
Contributor
Author
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds debug log statements to the activation-job compiler split-out files to improve observability during compilation.
Changes
All changes are additive — no logic, behaviour, or output is modified.
pkg/workflow/compiler_activation_daily_aic.gobuildActivationDailyAICGuardrailStepwithdedicated_appandcache_enabledflags.buildDailyAICActivationJobEnvwhenmax-daily-ai-creditsis set but empty (env omitted).pkg/workflow/compiler_activation_outputs.gopkg/workflow/compiler_activation_permissions.goghcommands in activation scripts (logs command count).pkg/workflow/compiler_yaml_post_agent.gogeneratePostAgentCollectionAndUpload.Motivation
The activation-job compiler logic was split across multiple files in a prior refactor. These log statements fill the observability gap left by that split, making it easier to trace compilation decisions (token minting, label handling, permission scoping, artifact collection) when debugging compiler output.
Testing
No functional changes; existing compiler tests cover correctness. Debug log output is gated by the existing
compilerActivationJobLog/compilerYamlLogloggers.