Accept ADR-43244 and add predicate traceability - #51611
Merged
Merged
Conversation
11 tasks
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update daily spec work plan for ADR-43244 and related specs
Accept ADR-43244 and add predicate traceability
Aug 9, 2026
pelikhan
approved these changes
Aug 9, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Accepts ADR-43244 and adds predicate-to-test traceability.
Changes:
- Marks the ADR Accepted with
@pelikhanas decider. - Adds a P1–P10 test mapping.
- Records the acceptance date.
Show a summary per file
| File | Description |
|---|---|
docs/adr/43244-formal-specification-testing-for-security-architecture-predicates.md |
Updates ADR governance and traceability. |
Review details
Tip
Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
Comment on lines
+19
to
+21
| | Predicate | Formal test | | ||
| | --- | --- | | ||
| | P1 InputNotDirectlyInterpolated | `TestFormal_P1_InputSanitizationRequired` | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADR-43244 remained Draft with an unknown decider despite its formal security predicate tests already existing. The ADR also lacked an explicit mapping from the security architecture predicates to their executable tests.
Decision record
@pelikhanas the decider.Traceability
TestFormal_P*coverage.