Skip to content

Accept ADR-43244 and add predicate traceability #51611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Aug 9, 2026
Merged

Accept ADR-43244 and add predicate traceability #51611

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e362f7
Initial plan
Copilot Aug 9, 2026
248ba8c
Accept security predicate testing ADR
Copilot Aug 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions .../adr/43244-formal-specification-testing-for-security-architecture-predicates.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# ADR-43244: Formal Specification Testing for Security Architecture Predicates

**Date**: 2026-07-04
**Status**: Draft
**Deciders**: Unknown
**Status**: Accepted
**Deciders**: @pelikhan

---

Expand All @@ -14,6 +14,21 @@ The gh-aw 7-layer security architecture is defined in `specs/security-architectu

We will add `pkg/workflow/security_architecture_formal_test.go` containing 10 `TestFormal_P*` functions—one per predicate—that call production code directly with no stubs, plus four file-local formal helpers (`formalConformanceMonotonicity`, `formalJobOrderValid`, `formalTokenAbsentFromEnv`, `formalValidationBlocksEmit`) for predicates whose invariants span multiple call sites. This makes the formal spec continuously verifiable in CI under the default (non-integration) build tag.

### Predicate-to-Test Traceability

| Predicate | Formal test |
| --- | --- |
| P1 InputNotDirectlyInterpolated | `TestFormal_P1_InputSanitizationRequired` |
Comment on lines +19 to +21
| P2 NoDirectAgentWrite | `TestFormal_P2_AgentHasNoWritePermissions` |
| P3 NetworkRestricted | `TestFormal_P3_NetworkDomainAllowlist` |
| P4 LeastPrivilege | `TestFormal_P4_DefaultPermissionsMinimal` |
| P5 AgentSandboxed | `TestFormal_P5_AgentMustRunInSandbox` |
| P6 FailSecure | `TestFormal_P6_SecurityFailureHaltsExecution` |
| P7 Monotonicity | `TestFormal_P7_ConformanceLevelMonotonicity` |
| P8 JobOrder | `TestFormal_P8_JobDependencyChainOrder` |
| P9 CompileValidates | `TestFormal_P9_CompilationValidatesBeforeEmit` |
| P10 TokenIsolation | `TestFormal_P10_WriteTokenIsolatedToSafeOutput` |

### Alternatives Considered

#### Alternative 1: Manual Code-Review Enforcement
Expand Down Expand Up @@ -45,4 +60,4 @@ Security invariants could be enforced at runtime in production code via `panic`

---

*ADR created by [adr-writer agent]. Review and finalize before changing status from Draft to Accepted.*
*Accepted by @pelikhan on 2026-08-09.*