fix: Display full help text for adk create CLI command when argument… #443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bl3ck
force-pushed
the
fix/cli-help-display
branch
from
874d226 to
f2eea8d
Compare
Collaborator
|
Thanks! @bl3ck could you show before/after command line log? |
hangfei
approved these changes
May 8, 2025
hangfei
added
the
ready to pull
Contributor
Author
hangfei
approved these changes
May 9, 2025
Collaborator
|
@bl3ck The error message is lower case "app_name". Could we match to its original case("APP_NAME")? |
Contributor
Author
copybara-service bot
pushed a commit
that referenced
this pull request
May 14, 2025
Copybara import of the project: -- dcfb9ff by Eugen-Bleck <eugenbleck@gmail.com>: fix: Display full help text for adk create CLI command when arguments are missing -- f2eea8d by Eugen-Bleck <eugenbleck@gmail.com>: fix: Display full help text for adk run and eval CLI command when arguments are missing COPYBARA_INTEGRATE_REVIEW=#443 from bl3ck:fix/cli-help-display c2bca42 PiperOrigin-RevId: 758498242
bl3ck
force-pushed
the
fix/cli-help-display
branch
from
0724098 to
71bd808
Compare
Contributor
Author
Collaborator
|
Thanks! Let's move the discussion to the other thread. |
coder-aditi
pushed a commit
to coder-aditi/adk-python
that referenced
this pull request
Jul 2, 2025
Copybara import of the project: -- dcfb9ff by Eugen-Bleck <eugenbleck@gmail.com>: fix: Display full help text for adk create CLI command when arguments are missing -- f2eea8d by Eugen-Bleck <eugenbleck@gmail.com>: fix: Display full help text for adk run and eval CLI command when arguments are missing COPYBARA_INTEGRATE_REVIEW=google#443 from bl3ck:fix/cli-help-display c2bca42 PiperOrigin-RevId: 758498242
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Display full help text for CLI commands when arguments are missing
Addresses issue #431 by implementing a custom Click Command class that shows the complete help text instead of just an error message when a required argument is missing. This improves user experience by following the common CLI convention where commands without options display their full help text.
HelpfulCommandclass to override default Click error behaviorcreate" commandThis change makes the CLI more intuitive and saves users from having to
run an additional
--helpcommand to see available options.How to test:
adk createwithout theAPP_NAME