fix: Match argument case when displaying errors for missing CLI arguments #724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hangfei
approved these changes
May 29, 2025
hangfei
added
the
ready to pull
Collaborator
whhlct
pushed a commit
to whhlct/adk-python
that referenced
this pull request
Jun 6, 2025
-- d9b0a6f by Eugen-Bleck <eugenbleck@gmail.com>: fix: match arg case in errors COPYBARA_INTEGRATE_REVIEW=google#724 from bl3ck:fix/preserve-arg-case-in-errors 3ac43ef PiperOrigin-RevId: 764953570
coder-aditi
pushed a commit
to coder-aditi/adk-python
that referenced
this pull request
Jul 2, 2025
-- d9b0a6f by Eugen-Bleck <eugenbleck@gmail.com>: fix: match arg case in errors COPYBARA_INTEGRATE_REVIEW=google#724 from bl3ck:fix/preserve-arg-case-in-errors 3ac43ef PiperOrigin-RevId: 764953570
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains a final commit from PR #443 that addresses @hangfei’s feedback. The original PR was closed before this change was merged.
It introduces a static method,
_format_missing_arg_error,to ensure that missing argument names in error messages preserve the correct case and match the original argument names in the CLI.Before
After
How to Test
adk createwithout specifyingAPP_NAMEadk runwithout specifyingAGENTadk evalwithout specifyingAGENT_MODULE_FILE_PATH