test: run the datastore system tests in google cloud build#8343
test: run the datastore system tests in google cloud build#8343danieljbruce wants to merge 6 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new Cloud Build configuration for the datastore component, covering dependency installation, system testing, and coverage reporting. Feedback focuses on correcting the Node.js image version to a stable release, adopting npm ci for more reliable builds, parameterizing the project ID, and reducing the build timeout to prevent resource waste.
| args: | ||
| - '-c' | ||
| - | | ||
| npm install |
There was a problem hiding this comment.
In CI environments, it is recommended to use npm ci instead of npm install. npm ci is faster, more reliable, and ensures that the installed dependencies exactly match the package-lock.json file, which helps avoid inconsistencies between environments.
npm ciThere was a problem hiding this comment.
Made this change
There was a problem hiding this comment.
Actually, this breaks the build so needs to be reverted.
| substitutions: | ||
| _GCP_PROJECT_ID: 'long-door-651' | ||
|
|
||
| timeout: '10800s' |
There was a problem hiding this comment.
A timeout of 3 hours (10800s) is very high. Unless the system tests are exceptionally long-running, it is safer to set a lower timeout (e.g., 3600s for 1 hour) to prevent unnecessary costs and resource consumption if a build hangs.
timeout: '3600s'There was a problem hiding this comment.
Made this change. Reduced the timeout to 1h.
danieljbruce
changed the title
danieljbruce
changed the title
2 participants
Description
This pull request adds a yaml file to instruct the Datastore system test CI check to work with the new Cloud Build trigger thereby making the new CI check effectively run our system tests. It also includes minor code modifications to the Datastore handwritten layer that allow the system tests to operate properly in the new Cloud Build Environment.
Impact
Leverages the strengths of running system tests in GCB rather than relying on kokoro for system tests.
Testing
This pull request tells the tests how to work with the new check to the continuous integration pipeline for the Datastore system tests thus improves the effectiveness of that test.
Next Steps