-
Notifications
You must be signed in to change notification settings - Fork 679
test: run the datastore system tests in google cloud build #8343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
danieljbruce
wants to merge
6
commits into
main
Choose a base branch
from
add-gcb-datastore-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ef667c7
add the cloudbuild.yaml file
danieljbruce 4d29005
Fix the packnplay cjs error
danieljbruce 73b9937
Reduce the datastore timeout period
danieljbruce 8bc9c0c
Use ci instead of npm install
danieljbruce cecf00f
use npm i, not npm ci
danieljbruce cabc23c
Merge branch 'main' into add-gcb-datastore-tests
danieljbruce File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| steps: | ||
| # 1. Set up Node.js environment | ||
| - name: 'node:24' | ||
| entrypoint: 'bash' | ||
| args: | ||
| - '-c' | ||
| - | | ||
| npm i | ||
| dir: 'handwritten/datastore' | ||
| id: 'install-dependencies' | ||
|
|
||
| # 2. Configure environment variables for the tests and run system tests | ||
| # - GOOGLE_APPLICATION_CREDENTIALS: GCB steps run as a service account | ||
| # that is typically granted permissions directly. Explicitly setting | ||
| # GOOGLE_APPLICATION_CREDENTIALS might not be needed if the GCB service | ||
| # account has the right roles (e.g., Datastore User, Datastore Index Admin). | ||
| # If you need to use specific service account key JSON, you'd store it | ||
| # in Secret Manager and mount it here. For simplicity, we'll rely on | ||
| # the GCB service account's inherent permissions. | ||
| # - GCLOUD_PROJECT: Can be passed as a build variable. | ||
| - name: 'node:24' | ||
|
pearigee marked this conversation as resolved.
|
||
| entrypoint: 'bash' | ||
| args: | ||
| - '-c' | ||
| - | | ||
| npm run system-test | ||
| dir: 'handwritten/datastore' | ||
| env: | ||
| - 'GCLOUD_PROJECT=${_GCP_PROJECT_ID}' # Pass project ID via build variable | ||
| # If you need specific credentials from Secret Manager, uncomment these: | ||
| # - 'GOOGLE_APPLICATION_CREDENTIALS=/secrets/sa-key.json' | ||
| id: 'run-system-tests' | ||
| waitFor: ['install-dependencies'] | ||
| # For Secret Manager, uncomment these (adjust secret name and volume path as needed): | ||
| # secretEnv: ['SA_KEY'] | ||
| # volumes: | ||
| # - name: 'sa-keys' | ||
| # path: '/secrets' | ||
|
|
||
| # 3. (Optional) Code Coverage Reporting | ||
| - name: 'node:24' | ||
|
pearigee marked this conversation as resolved.
|
||
| entrypoint: 'bash' | ||
| args: | ||
| - '-c' | ||
| - | | ||
| # Check if nyc is installed and run report | ||
| if [ -f ./node_modules/nyc/bin/nyc.js ]; then | ||
| ./node_modules/nyc/bin/nyc.js report || true # `|| true` prevents build failure if nyc report itself exits non-zero | ||
| else | ||
| echo "nyc not found, skipping coverage report." | ||
| fi | ||
| # The original codecov.sh script from Kokoro needs to be made available to GCB. | ||
| # Options: | ||
| # a) Commit codecov.sh into your repo (e.g., .kokoro/codecov.sh) and call it: | ||
| # if [ -f .kokoro/codecov.sh ]; then . ./.kokoro/codecov.sh; fi | ||
| # b) Replicate its functionality directly in this step. | ||
| # c) Store it in a GCS bucket and fetch it. | ||
| echo "Codecov reporting (if desired) would be integrated here." | ||
| dir: 'handwritten/datastore' | ||
| id: 'coverage-report' | ||
| waitFor: ['run-system-tests'] | ||
|
|
||
| # If you use Secret Manager for credentials, uncomment and configure: | ||
| # availableSecrets: | ||
| # secretManager: | ||
| # - versionName: projects/${PROJECT_ID}/secrets/YOUR_SERVICE_ACCOUNT_KEY_SECRET_NAME/versions/latest | ||
| # env: 'SA_KEY' # This env var will hold the secret value. Use it as GOOGLE_APPLICATION_CREDENTIALS in step 3 if needed. | ||
|
|
||
| # Define a substitution variable for your project ID | ||
| # Replace 'long-door-651' with the actual GCP Project ID your system tests should run against. | ||
| substitutions: | ||
| _GCP_PROJECT_ID: 'long-door-651' | ||
|
pearigee marked this conversation as resolved.
|
||
|
|
||
| timeout: '3600s' | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.