chore: local OwlBot regeneration - #8641
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates several Node.js client libraries, including google-cloud-capacityplanner, google-cloud-domains, google-monitoring-dashboard, and grafeas. Key updates include proto definition changes, dependency updates, and API surface adjustments, such as removing the CapacityPlanningService from the capacity planner package and adding risk and secret kind details to Grafeas. However, a critical issue was identified in the package.json files for both google-cloud-capacityplanner and google-monitoring-dashboard, where the package versions were incorrectly downgraded and the repository configurations were overwritten with standalone repository templates. These packages must be regenerated using the correct monorepo templates to preserve their metadata.
422ec75 to
5ae99c1
Compare
5ae99c1 to
0205153
Compare
feywind
left a comment
feywind
left a comment
There was a problem hiding this comment.
My comments are almost entirely about READMEs, so I guess I'm okay with merging this one and coming back to fix templates later.
| 1. [Select or create a Cloud Platform project][projects]. | ||
| 1. [Enable billing for your project][billing]. | ||
| 1. [Enable the Cloud Domains API][enable_api]. | ||
| 1. [Enable the Cloud Domains API API][enable_api]. |
There was a problem hiding this comment.
This doesn't look correct.
|
|
||
| | Sample | Source Code | | ||
| | --------------------------- | --------------------------------- | | ||
| | configure contact settings | [source code](https://github.com/googleapis/google-cloud-node/blob/main/packages/google-domains/samples/generated/v1/domains.configure_contact_settings.js) | |
There was a problem hiding this comment.
Again on the lack of cloud shell links - is that on purpose?
| @@ -1,3 +0,0 @@ | |||
| introduction: |- | |||
| A [Grafeas API Client](https://grafeas.io/) compatible with Google Cloud's | |||
There was a problem hiding this comment.
I had a fix for this in some other PR I probably can't find now. Just removing the apostrophe fixes it, so e.g. "the Google Cloud Container Analysis..."
| [](https://www.npmjs.org/package/@google-cloud/grafeas) | ||
|
|
||
| Grafeas API client for Node.js | ||
| Container Analysis API client for Node.js |
| [the CHANGELOG](https://github.com/googleapis/google-cloud-node/tree/main/packages/grafeas/CHANGELOG.md). | ||
| [the CHANGELOG][homepage_changelog]. | ||
|
|
||
| * [Container Analysis API Nodejs Client API Reference](https://cloud.google.com/nodejs/docs/reference/grafeas/latest) |
There was a problem hiding this comment.
Likewise here, and the removed Grafeas links.
|
|
||
| 1. [Select or create a Cloud Platform project][projects]. | ||
| 1. [Enable the Grafeas API][enable_api]. | ||
| 1. [Enable billing for your project][billing]. |
There was a problem hiding this comment.
These two lines also look weird.
|
|
||
| | Sample | Source Code | | ||
| | --------------------------- | --------------------------------- | | ||
| | batch create notes | [source code](https://github.com/googleapis/google-cloud-node/blob/main/packages/grafeas/samples/generated/v1/grafeas.batch_create_notes.js) | |
| | update occurrence | [source code](https://github.com/googleapis/google-cloud-node/blob/main/packages/grafeas/samples/generated/v1/grafeas.update_occurrence.js) | | ||
|
|
||
|
|
||
| The [Grafeas Node.js Client API Reference][client-docs] documentation |
There was a problem hiding this comment.
I wonder if this is related to the removal of the Grafeas links above.
|
|
||
|
|
||
|
|
||
| This library is considered to be **stable**. The code surface will not change in backwards-incompatible ways |
3 participants
Performs OwlBot copying/post-processing on:
Note that in the grafeas commit,
.readme-partials.yamlis removed as it was interfering with OwlBot post-processing.