feat: regenerated google-cloud-capacityplanner - #8642
Conversation
|
This has been split from #8641 due to test failures. |
There was a problem hiding this comment.
Code Review
This pull request removes the CapacityPlanningService from the @google-cloud/capacityplanner package, leaving only the UsageService. It also updates the UsageService proto definitions to make several fields required (such as cloud_resource_type, reservation_type, and reservation_data_level) and updates the generated samples and client code accordingly. Feedback was provided regarding the package version downgrade to 0.1.0 (which would fail npm publishing since 0.1.3 is already released) and the use of a pre-release version of google-gax in the dependencies.
|
Reverted README.md and package.json changes; I believe this should be good to go now. |
| library: 'CapacityPlanningService', | ||
| filename: './capacity-planning-service.js', | ||
| library: 'UsageService', | ||
| filename: './usage-service.js', |
There was a problem hiding this comment.
I don't know enough about webpack to know what this is doing... was it right before? Is it right now?
feywind
left a comment
There was a problem hiding this comment.
It looks like, overall, CapacityPlanningServiceClient has completely vanished off the face of the package. I'm not sure why it's not being generated anymore, but that seems to be the source of the test failures.
Note for myself: |
|
#8713 is a new pull request forked from this. |
No description provided.