Skip to content

feat: regenerated google-cloud-capacityplanner - #8642

Closed
jskeet wants to merge 2 commits into
googleapis:mainfrom
jskeet:local-owlbot-capacityplanning
Closed

feat: regenerated google-cloud-capacityplanner#8642
jskeet wants to merge 2 commits into
googleapis:mainfrom
jskeet:local-owlbot-capacityplanning

Conversation

@jskeet

@jskeet jskeet commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@jskeet
jskeet requested a review from a team as a code owner June 15, 2026 11:18
@jskeet

jskeet commented Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

This has been split from #8641 due to test failures.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the CapacityPlanningService from the @google-cloud/capacityplanner package, leaving only the UsageService. It also updates the UsageService proto definitions to make several fields required (such as cloud_resource_type, reservation_type, and reservation_data_level) and updates the generated samples and client code accordingly. Feedback was provided regarding the package version downgrade to 0.1.0 (which would fail npm publishing since 0.1.3 is already released) and the use of a pre-release version of google-gax in the dependencies.

Comment thread packages/google-cloud-capacityplanner/package.json Outdated
Comment thread packages/google-cloud-capacityplanner/package.json Outdated
@jskeet
jskeet requested a review from feywind June 17, 2026 07:03
@jskeet

jskeet commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

Reverted README.md and package.json changes; I believe this should be good to go now.

library: 'CapacityPlanningService',
filename: './capacity-planning-service.js',
library: 'UsageService',
filename: './usage-service.js',

@jskeet jskeet Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know enough about webpack to know what this is doing... was it right before? Is it right now?

@feywind feywind left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like, overall, CapacityPlanningServiceClient has completely vanished off the face of the package. I'm not sure why it's not being generated anymore, but that seems to be the source of the test failures.

@suztomo

suztomo commented Jun 23, 2026

Copy link
Copy Markdown
Member

CapacityPlanningServiceClient has completely vanished off the face of the package.

Note for myself:

test/gapic_capacity_planning_service_v1beta.ts:952:69 - error TS2339: Property 'CapacityPlanningServiceClient' does not exist on type 'typeof import("/home/runner/work/google-cloud-node/google-cloud-node/packages/google-cloud-capacityplanner/src/v1beta/index")'.

952             const client = new capacityplanningserviceModule.v1beta.CapacityPlanningServiceClient({
                                                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

test/gapic_capacity_planning_service_v1beta.ts:984:69 - error TS2339: Property 'CapacityPlanningServiceClient' does not exist on type 'typeof import("/home/runner/work/google-cloud-node/google-cloud-node/packages/google-cloud-capacityplanner/src/v1beta/index")'.

984             const client = new capacityplanningserviceModule.v1beta.CapacityPlanningServiceClient({
                                                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

test/gapic_capacity_planning_service_v1beta.ts:1030:69 - error TS2339: Property 'CapacityPlanningServiceClient' does not exist on type 'typeof import("/home/runner/work/google-cloud-node/google-cloud-node/packages/google-cloud-capacityplanner/src/v1beta/index")'.

1030             const client = new capacityplanningserviceModule.v1beta.CapacityPlanningServiceClient({

@suztomo

suztomo commented Jun 23, 2026

Copy link
Copy Markdown
Member

#8713 is a new pull request forked from this.

@suztomo suztomo closed this Jun 23, 2026
@jskeet
jskeet deleted the local-owlbot-capacityplanning branch July 8, 2026 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants