Conversation
Contributor
|
💻 Deploy preview available (Add virtual node config arguments to otelcol.connector.servicegraph): |
docs/sources/reference/components/otelcol/otelcol.connector.servicegraph.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.connector.servicegraph.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.connector.servicegraph.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.connector.servicegraph.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.connector.servicegraph.md
Outdated
Show resolved
Hide resolved
clayton-cornell
added
the
type/docs
ptodev
changed the title
virtual_node_peer_attributes and virtual_node_extra_label arguments to otelcol.connector.servicegraph
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
ptodev
force-pushed
the
ptodev/virtualnode
branch
from
8d18067 to
27c3b8e
Compare
Contributor
|
💻 Deploy preview deleted (feat: Add a |
clayton-cornell
approved these changes
Jan 13, 2026
Contributor
clayton-cornell
left a comment
clayton-cornell
left a comment
There was a problem hiding this comment.
Approving for docs. The conditions make sense to me :-)
blewis12
reviewed
Jan 13, 2026
internal/converter/internal/otelcolconvert/converter_servicegraphconnector.go
Show resolved
Hide resolved
blewis12
approved these changes
Jan 13, 2026
Member
blewis12
left a comment
blewis12
left a comment
There was a problem hiding this comment.
LGTM 👍 just one question about ExponentialHistogramMaxSize
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Adding a couple of extra config arguments.
This change is almost the same as #879, so I have included @hainenber in the changelog credits :)
Which issue(s) this PR fixes
Fixes #861
Notes to the Reviewer
There is also a feature gate to control this behaviour, but it's enabled by default and I don't think it's necessary.
PR Checklist