feat(otelcol/connector/servicegraph): add `virtual_node_peer_attributes` setting to the component by hainenber · Pull Request #879 · grafana/alloy

hainenber · 2024-05-16T14:38:02Z

PR Description

Add the virtual_node_peer_attributes setting to otelcol.connector.servicegraph. Thanks @erikbaranowski for creating the foundation already!

The default attributes are reduced to be identical to upstream

Which issue(s) this PR fixes

Closes #861

Notes to the Reviewer

PR Checklist

CHANGELOG.md updated
Documentation added
Tests updated
Config converters updated

…es` setting to the component Signed-off-by: hainenber <dotronghai96@gmail.com>

CHANGELOG.md

docs/sources/reference/components/otelcol.connector.servicegraph.md

Co-authored-by: William Dumont <william.dumont@grafana.com>

Signed-off-by: hainenber <dotronghai96@gmail.com>

wildum

LGTM, thanks!

wildum · 2024-05-23T09:59:53Z

waiting for @clayton-cornell feedback on the doc before merging it

docs/sources/reference/components/otelcol.connector.servicegraph.md

CHANGELOG.md

docs/sources/reference/components/otelcol.connector.servicegraph.md

…telcol-connector-servicegraph

Co-authored-by: Paulin Todev <paulin.todev@gmail.com> Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>

Signed-off-by: hainenber <dotronghai96@gmail.com>

…telcol-connector-servicegraph

ptodev

I opened a PR upstream for this config option to be changed upstream. It would be better to update Alloy straight to the new config, so let's put the PR on hold for now to see if the upstream PR gets accepted.

hainenber · 2024-05-29T15:04:13Z

All fine by me :D

clayton-cornell

Still in passive voice, but leaving it as it gets the technical point across.

clayton-cornell · 2024-05-30T19:23:39Z

docs/sources/reference/components/otelcol.connector.servicegraph.md


 When `metrics_flush_interval` is set to `0s`, metrics will be flushed on every received batch of traces.

+`virtual_node_peer_attributes` is useful when an OTel-instrumented client sends a request to a service which is not OTel-instrumented.


Suggested change

`virtual_node_peer_attributes` is useful when an OTel-instrumented client sends a request to a service which is not OTel-instrumented.

`virtual_node_peer_attributes` is useful when an OTel-instrumented client sends a request to a service that is not OTel-instrumented.

clayton-cornell · 2024-05-30T19:24:44Z

docs/sources/reference/components/otelcol.connector.servicegraph.md

+
+If no client span is found and `virtual_node_peer_attributes` is not an empty list,
+then the service span will be paired with a virtual node called `client="user"`.
+This can be useful when a client which is not OTel-instrumented (like a web browser) sends a request to an OTel-instrumented service. 


Suggested change

This can be useful when a client which is not OTel-instrumented (like a web browser) sends a request to an OTel-instrumented service.

This can be useful when a client that is not OTel-instrumented (like a web browser) sends a request to an OTel-instrumented service.

clayton-cornell · 2024-05-30T19:36:03Z

docs/sources/reference/components/otelcol.connector.servicegraph.md

 When `metrics_flush_interval` is set to `0s`, metrics will be flushed on every received batch of traces.

+`virtual_node_peer_attributes` is useful when an OTel-instrumented client sends a request to a service which is not OTel-instrumented.
+Normally, `otelcol.connector.servicegraph` wouldn't be able to pair the client span with a service span, 


Suggested change

Normally, `otelcol.connector.servicegraph` wouldn't be able to pair the client span with a service span,

Normally, `otelcol.connector.servicegraph` wouldn't be able to pair the client span with a service span

github-actions · 2024-06-30T00:01:25Z

This PR has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

CLAassistant · 2025-04-02T19:35:30Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

CLAassistant · 2025-04-02T19:35:58Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

ptodev · 2025-12-10T15:07:38Z

@hainenber I'll close this one in favour of #5058, which is up to date and includes an additional config argument.

There is still a feature gate but since it's enabled by default I don't think it's a problem. I suppose that the feature gate was either disabled by default at the time of your PR, or we missed the fact that it's not that important 😅

feat(otelcol/connector/servicegraph): add `virtual_node_peer_attribut…

67c4780

…es` setting to the component Signed-off-by: hainenber <dotronghai96@gmail.com>

hainenber requested a review from clayton-cornell as a code owner May 16, 2024 14:38

wildum reviewed May 22, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

docs/sources/reference/components/otelcol.connector.servicegraph.md Outdated Show resolved Hide resolved

hainenber and others added 2 commits May 22, 2024 22:51

Update CHANGELOG.md

9da20cc

Co-authored-by: William Dumont <william.dumont@grafana.com>

doc: add note regarding servicegraph's virtual_node_peer_attributes

5f04bc6

Signed-off-by: hainenber <dotronghai96@gmail.com>

wildum approved these changes May 23, 2024

View reviewed changes

clayton-cornell reviewed May 23, 2024

View reviewed changes

docs/sources/reference/components/otelcol.connector.servicegraph.md Outdated Show resolved Hide resolved

docs/sources/reference/components/otelcol.connector.servicegraph.md Outdated Show resolved Hide resolved

ptodev reviewed May 28, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

docs/sources/reference/components/otelcol.connector.servicegraph.md Outdated Show resolved Hide resolved

hainenber and others added 5 commits May 28, 2024 22:06

Merge branch 'main' into add-virtual-node-peer-attribute-setting-to-o…

811bca0

…telcol-connector-servicegraph

Apply suggestions from code review

9bad68b

Co-authored-by: Paulin Todev <paulin.todev@gmail.com> Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>

Update otelcol.connector.servicegraph.md

9008da4

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>

doc: add Paulin's suggested note

03e4b8a

Signed-off-by: hainenber <dotronghai96@gmail.com>

Merge branch 'main' into add-virtual-node-peer-attribute-setting-to-o…

14e3f21

…telcol-connector-servicegraph

ptodev requested changes May 29, 2024

View reviewed changes

hainenber marked this pull request as draft May 29, 2024 16:40

clayton-cornell reviewed May 30, 2024

View reviewed changes

github-actions bot added the needs-attention label Jun 30, 2024

ptodev mentioned this pull request Dec 10, 2025

feat: Add a virtual_node_peer_attributes and virtual_node_extra_label arguments to otelcol.connector.servicegraph #5058

Merged

4 tasks

ptodev closed this Dec 10, 2025

github-actions bot added the frozen-due-to-age label Dec 25, 2025

github-actions bot locked as resolved and limited conversation to collaborators Dec 25, 2025


		When `metrics_flush_interval` is set to `0s`, metrics will be flushed on every received batch of traces.

		`virtual_node_peer_attributes` is useful when an OTel-instrumented client sends a request to a service which is not OTel-instrumented.

	This can be useful when a client which is not OTel-instrumented (like a web browser) sends a request to an OTel-instrumented service.
	This can be useful when a client that is not OTel-instrumented (like a web browser) sends a request to an OTel-instrumented service.

	Normally, `otelcol.connector.servicegraph` wouldn't be able to pair the client span with a service span,
	Normally, `otelcol.connector.servicegraph` wouldn't be able to pair the client span with a service span

Conversation

hainenber commented May 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Description

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

Uh oh!

Uh oh!

Uh oh!

wildum left a comment

Choose a reason for hiding this comment

Uh oh!

wildum commented May 23, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ptodev left a comment

Choose a reason for hiding this comment

Uh oh!

hainenber commented May 29, 2024

Uh oh!

clayton-cornell left a comment

Choose a reason for hiding this comment

Uh oh!

clayton-cornell May 30, 2024

Choose a reason for hiding this comment

Uh oh!

clayton-cornell May 30, 2024

Choose a reason for hiding this comment

Uh oh!

clayton-cornell May 30, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jun 30, 2024

Uh oh!

CLAassistant commented Apr 2, 2025

Uh oh!

CLAassistant commented Apr 2, 2025

Uh oh!

ptodev commented Dec 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

hainenber commented May 16, 2024 •

edited

Loading