Skip to content

docs: Improve information about how each daemonset pod watches ALL pods logs in the cluster#5359

Merged
clayton-cornell merged 8 commits intomainfrom
docs/fix-admonitions-discovery.kubernetes
Feb 5, 2026
Merged

docs: Improve information about how each daemonset pod watches ALL pods logs in the cluster#5359
clayton-cornell merged 8 commits intomainfrom
docs/fix-admonitions-discovery.kubernetes

Conversation

@clayton-cornell
Copy link
Contributor

Fix admonitions around info explaining that each daemonset pod watches ALL pods logs in the cluster.

General topic cleanup, with a focus on language, readability, active voice, and grammar.

Fixes #4793

@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Jan 27, 2026
@clayton-cornell clayton-cornell changed the title Improve information about how each daemonset pod watches ALL pods logs in the cluster docs: Improve information about how each daemonset pod watches ALL pods logs in the cluster Jan 27, 2026
@github-actions
Copy link
Contributor

💻 Deploy preview available (Improve information about how each daemonset pod watches ALL pods logs in the cluster):

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the discovery.kubernetes documentation with a focus on clarifying DaemonSet deployment behavior, language clarity, and readability. The changes address issue #4793 by adding prominent admonitions about performance considerations when running in DaemonSet mode.

Changes:

  • Added a caution admonition highlighting that each DaemonSet Pod watches all cluster resources by default, which can cause significant API server load
  • General documentation cleanup including grammar improvements, active voice conversion, and better readability
  • Fixed typos and improved consistency in formatting (bullet lists, table formatting)

@clayton-cornell clayton-cornell requested a review from a team January 27, 2026 10:10
@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2026

💻 Deploy preview deleted (docs: Improve information about how each daemonset pod watches ALL pods logs in the cluster).

Copy link
Member

@blewis12 blewis12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thank you including the caution regarding daemonsets, this has come up in escalations i've seen already

@clayton-cornell clayton-cornell added backport/v1.12 Backport to release/v1.12 backport/v1.13 Backport to release/v1.13 labels Feb 5, 2026
@clayton-cornell clayton-cornell merged commit 8b3e33f into main Feb 5, 2026
59 checks passed
@clayton-cornell clayton-cornell deleted the docs/fix-admonitions-discovery.kubernetes branch February 5, 2026 09:45
grafana-alloybot bot pushed a commit that referenced this pull request Feb 5, 2026
…ds logs in the cluster (#5359)

Fix admonitions around info explaining that each daemonset pod watches
ALL pods logs in the cluster.

General topic cleanup, with a focus on language, readability, active
voice, and grammar.

Fixes #4793

(cherry picked from commit 8b3e33f)
grafana-alloybot bot pushed a commit that referenced this pull request Feb 5, 2026
…ds logs in the cluster (#5359)

Fix admonitions around info explaining that each daemonset pod watches
ALL pods logs in the cluster.

General topic cleanup, with a focus on language, readability, active
voice, and grammar.

Fixes #4793

(cherry picked from commit 8b3e33f)
clayton-cornell added a commit that referenced this pull request Feb 5, 2026
…ds logs in the cluster [backport] (#5452)

## Backport of #5359

This PR backports #5359 to release/v1.13.

### Original PR Title
docs: Improve information about how each daemonset pod watches ALL pods
logs in the cluster

### Original PR Author
@clayton-cornell

### Description
Fix admonitions around info explaining that each daemonset pod watches
ALL pods logs in the cluster.

General topic cleanup, with a focus on language, readability, active
voice, and grammar.

Fixes #4793

---
*This backport was created automatically.*

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
clayton-cornell added a commit that referenced this pull request Feb 5, 2026
…ds logs in the cluster [backport] (#5451)

## Backport of #5359

This PR backports #5359 to release/v1.12.

### Original PR Author
@clayton-cornell

### Description
Fix admonitions around info explaining that each daemonset pod watches
ALL pods logs in the cluster.

General topic cleanup, with a focus on language, readability, active
voice, and grammar.

Fixes #4793

---
*This backport was created automatically.*

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/v1.12 Backport to release/v1.12 backport/v1.13 Backport to release/v1.13 frozen-due-to-age type/docs Docs Squad label across all Grafana Labs repos

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add admonitions in discovery.kubernetes to clarify

3 participants