WIP: Graphene 3#774
Closed
ktosiek wants to merge 18 commits into
Closed
Conversation
Fields starting with __ are reserved for introspection
graphql-core 3 prints the descriptions, and skips `schema` if it's the default one (query: Query)
Connection resolvers have access to pagination arguments.
Some of the tests show the problem described here: graphql-python/graphql-core#61
It was only needed for Python 2.7
Member
|
This is great! Thanks so much @ktosiek . Is there anything outstanding left to do? |
Contributor
Author
|
Contributor
Author
|
|
@ktosiek I am going to run this against few of our projects tests. |
This was referenced Nov 20, 2019
|
Anyone please review it ASAP. It will be helpful for my project... upgrqaded to Django v3 with Graphene v3 and Graphene-Django v3. thanks. @ #812 |
Collaborator
|
@ktosiek Is this still WIP? |
Contributor
Author
Closed
Collaborator
|
@jkimbo Just give me some time to fix those test config. I'm saying that everything is already in place 🙂 No need for any additional work here. |
Member
|
Closing this since #951 has been merged into the v3 branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #705. I've started working on porting graphene-django to Graphene 3.
For now I'm just fixing tests from the top, but I'm sharing this in case anyone else is intrested.