Skip to content

WIP: Graphene 3#774

Closed
ktosiek wants to merge 18 commits into
graphql-python:masterfrom
ktosiek:graphene-3
Closed

WIP: Graphene 3#774
ktosiek wants to merge 18 commits into
graphql-python:masterfrom
ktosiek:graphene-3

Conversation

@ktosiek

@ktosiek ktosiek commented Sep 15, 2019

Copy link
Copy Markdown
Contributor

Related to #705. I've started working on porting graphene-django to Graphene 3.
For now I'm just fixing tests from the top, but I'm sharing this in case anyone else is intrested.

@jkimbo

jkimbo commented Sep 22, 2019

Copy link
Copy Markdown
Member

This is great! Thanks so much @ktosiek . Is there anything outstanding left to do?

@ktosiek

ktosiek commented Sep 23, 2019

Copy link
Copy Markdown
Contributor Author
  1. This is blocked by SourceLocation should be serialized as object graphql-core#61 (which I hope to finish soon).
  2. This was never used in an application (except for the cookbook example), so it might be incomplete.
  3. I haven't looked through documentation yet, it might still reference Python 2 or Django Filters 1.x

@ktosiek

ktosiek commented Sep 26, 2019

Copy link
Copy Markdown
Contributor Author
  1. SourceLocation should be serialized as object graphql-core#61 is done, and I've updated this PR accordingly.
  2. Still no real-world testing, and I'm not sure when I'll be able to do that (the only app I could try this on uses django-graphql-optimizer heavily).
  3. I've looked through the docs, (but not very thoroughly, to be honest), and fixed 2 references to Django <1.11.

@ghost ghost mentioned this pull request Nov 14, 2019
7 tasks
@ghost

ghost commented Nov 19, 2019

Copy link
Copy Markdown

@ktosiek I am going to run this against few of our projects tests.

@BfutureP

Copy link
Copy Markdown

Anyone please review it ASAP. It will be helpful for my project... upgrqaded to Django v3 with Graphene v3 and Graphene-Django v3. thanks. @ #812

@BfutureP BfutureP left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@ulgens

ulgens commented Mar 1, 2020

Copy link
Copy Markdown
Collaborator

@ktosiek Is this still WIP?

@ktosiek

ktosiek commented Mar 1, 2020

Copy link
Copy Markdown
Contributor Author

@ulgens I'm not working on this at the moment, but I see @ganwell has taken over in a separate PR: #812.

@ulgens ulgens mentioned this pull request Mar 15, 2020
@ghost

ghost commented Apr 6, 2020

Copy link
Copy Markdown

@jkimbo I fear that tox was not working on #904 and #905. I want to start over and incrementally (a PR and review per commit) merge #774. I also have some issues with flaky tests on master and I want to fix that first in master: Introducing random test order.

@ulgens

ulgens commented Apr 6, 2020

Copy link
Copy Markdown
Collaborator

@jkimbo Just give me some time to fix those test config. I'm saying that everything is already in place 🙂 No need for any additional work here.

@jkimbo

jkimbo commented May 9, 2020

Copy link
Copy Markdown
Member

Closing this since #951 has been merged into the v3 branch

@jkimbo jkimbo closed this May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants