graphql 3.0 and graphene 3.0 final rebase#951
Merged
Conversation
ghost
changed the title
ghost
marked this pull request as ready for review
ghost
changed the title
winged
suggested changes
May 1, 2020
Author
jkimbo
requested changes
May 1, 2020
jkimbo
left a comment
jkimbo
left a comment
Member
There was a problem hiding this comment.
This is looking good thanks @ganwell ! 1 minor suggestion.
Member
|
@ganwell I've just merged the github actions migration into v3 so you'll have to rebase this change on top of that (sorry) |
* Update mentions of django 1.11 and 2.0
Fields starting with __ are reserved for introspection
Connection resolvers have access to pagination arguments.
Some of the tests show the problem described here: graphql-python/graphql-core#61
It was only needed for Python 2.7
…ray_slice connection_from_list_slice: > Deprecated alias for connection_from_array_slice. We're now using the JavaScript terminology in Python as well, since list is too narrow a type and there is no other really appropriate type name. https://github.com/graphql-python/graphql-relay-py/blob/v3.0.0/src/graphql_relay/connection/arrayconnection.py#L54
* names must be strings * update to expected schemas to new format * Call get() on django promises to get the actual value
ghost
changed the title
Author
|
@jkimbo this is hopfully the final rebase. I rebased all original commits from @ktosiek and @ulgens in to this PR. The diff to the version that was reviewed is trivial: https://git.io/Jfsh3 |
winged
approved these changes
May 4, 2020
winged
left a comment
winged
left a comment
There was a problem hiding this comment.
I like :) Nice work on the rebase / re-include of the contributors as well!
jkimbo
approved these changes
May 9, 2020
jkimbo
left a comment
jkimbo
left a comment
Member
There was a problem hiding this comment.
👍looks good @ganwell . Thanks for all your work on this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I rebased almost all change to their original author: form #905 and #774.