Fix NdrCString not accepting strings in python3#85
Conversation
PyTest Results for 3.11-64520 tests ±0 460 ✅ - 4 2m 36s ⏱️ +7s For more details on these failures, see this check. Results for commit 19da4ad. ± Comparison against base commit c46f086. ♻️ This comment has been updated with latest results. |
PyTest Results for 2.7-32520 tests ±0 486 ✅ - 4 2m 50s ⏱️ -35s For more details on these failures, see this check. Results for commit 19da4ad. ± Comparison against base commit c46f086. ♻️ This comment has been updated with latest results. |
PyTest Results for 3.6-64520 tests ±0 508 ✅ - 4 2m 55s ⏱️ +16s For more details on these failures, see this check. Results for commit 19da4ad. ± Comparison against base commit c46f086. ♻️ This comment has been updated with latest results. |
PyTest Results for 3.11-32520 tests ±0 438 ✅ - 4 3m 31s ⏱️ +55s For more details on these failures, see this check. Results for commit 19da4ad. ± Comparison against base commit c46f086. ♻️ This comment has been updated with latest results. |
PyTest Results for 2.7-64520 tests ±0 508 ✅ - 4 2m 38s ⏱️ -11s For more details on these failures, see this check. Results for commit 19da4ad. ± Comparison against base commit c46f086. ♻️ This comment has been updated with latest results. |
PyTest Results for 3.6-32520 tests ±0 486 ✅ - 4 3m 11s ⏱️ -1s For more details on these failures, see this check. Results for commit 19da4ad. ± Comparison against base commit c46f086. ♻️ This comment has been updated with latest results. |
|
Superseed by #86 |
1 participant
Fix #84
Windows does seems to accept any bitstream that ends with
\x00for anFC_C_CSTRING.But for now, NdrCString use ascii encoding to be sure that encoding keep the same number of bytes that the input string.
I could also accept
bytes()(and would apply no modification) to allow the user to send whatever it wants.Same for
NdrWString