Add tests for NdrCString & NdrWString packing#86
Merged
Conversation
PyTest Results for 3.11-32524 tests +4 446 ✅ +4 2m 42s ⏱️ +6s Results for commit d6ad334. ± Comparison against base commit c46f086. This pull request removes 15 and adds 19 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
PyTest Results for 2.7-32524 tests +4 494 ✅ +4 2m 36s ⏱️ -49s Results for commit d6ad334. ± Comparison against base commit c46f086. This pull request removes 15 and adds 19 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
PyTest Results for 2.7-64524 tests +4 516 ✅ +4 2m 32s ⏱️ -17s Results for commit c7c8830. ± Comparison against base commit c46f086. This pull request removes 15 and adds 19 tests. Note that renamed tests count towards both. |
PyTest Results for 2.7-64524 tests +4 516 ✅ +4 2m 30s ⏱️ -19s Results for commit d6ad334. ± Comparison against base commit c46f086. This pull request removes 15 and adds 19 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
PyTest Results for 3.6-64524 tests +4 516 ✅ +4 2m 41s ⏱️ +2s Results for commit d6ad334. ± Comparison against base commit c46f086. This pull request removes 15 and adds 19 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
PyTest Results for 3.6-32524 tests +4 488 ✅ - 2 2m 57s ⏱️ -13s For more details on these failures, see this check. Results for commit c7c8830. ± Comparison against base commit c46f086. This pull request removes 15 and adds 19 tests. Note that renamed tests count towards both. |
PyTest Results for 3.6-32524 tests +4 494 ✅ +4 3m 3s ⏱️ -7s Results for commit d6ad334. ± Comparison against base commit c46f086. This pull request removes 15 and adds 19 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
PyTest Results for 3.11-64524 tests +4 468 ✅ +4 2m 34s ⏱️ +5s Results for commit d6ad334. ± Comparison against base commit c46f086. This pull request removes 15 and adds 19 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #84
Windows does seems to accept any bitstream that ends with
\x00for anFC_C_CSTRING.But for now,
NdrCStringuse ascii encoding to be sure that encoding keep the same number of bytes that the input string.I could also accept bytes() (and would apply no modification) to allow the user to send whatever it wants.
Same for
NdrWString#84 also made me realize there was no test for
NdrCString&NdrWStringpacking. I added some.